Deleting void pointers is bad, mmmkay?

Deleting void pointers is bad, mmmkay?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129483003

Committed: https://skia.googlesource.com/skia/+/47e3dbaab5396febbe6173000ea88cca1cf9c211

[jvanverth1, 2016-07-06 20:42:09]

Description was changed from

==========
Deleting void pointers is bad, mmmkay?

BUG=skia:
==========

to

==========
Deleting void pointers is bad, mmmkay?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129483003
==========

[jvanverth1, 2016-07-06 20:48:56]

jvanverth@google.com changed reviewers:
+ bungeman@google.com, dogben@google.com

[jvanverth1, 2016-07-06 20:49:50]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-07-06 20:50:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 20:50:05]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-07-07 02:50 UTC

[robertphillips, 2016-07-06 20:50:32]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-07-06 20:50:32]

lgtm

[commit-bot: I haz the power, 2016-07-06 21:26:55]

Description was changed from

==========
Deleting void pointers is bad, mmmkay?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129483003
==========

to

==========
Deleting void pointers is bad, mmmkay?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129483003

Committed:
https://skia.googlesource.com/skia/+/47e3dbaab5396febbe6173000ea88cca1cf9c211
==========

[commit-bot: I haz the power, 2016-07-06 21:26:56]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/47e3dbaab5396febbe6173000ea88cca1cf9c211

[egdaniel, 2016-07-07 02:58:07]

egdaniel@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-07-07 02:58:08]

https://codereview.chromium.org/2129483003/diff/1/src/gpu/vk/GrVkBuffer.cpp
File src/gpu/vk/GrVkBuffer.cpp (right):

https://codereview.chromium.org/2129483003/diff/1/src/gpu/vk/GrVkBuffer.cpp#n...
src/gpu/vk/GrVkBuffer.cpp:156: delete (unsigned char*) fMapPtr;
should this be using delete[]?

[jvanverth1, 2016-07-07 13:57:55]

On 2016/07/07 02:58:08, egdaniel wrote:
> https://codereview.chromium.org/2129483003/diff/1/src/gpu/vk/GrVkBuffer.cpp
> File src/gpu/vk/GrVkBuffer.cpp (right):
> 
>
https://codereview.chromium.org/2129483003/diff/1/src/gpu/vk/GrVkBuffer.cpp#n...
> src/gpu/vk/GrVkBuffer.cpp:156: delete (unsigned char*) fMapPtr;
> should this be using delete[]?

Good catch, I'll fix this in the next patch.