Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2129443002:
Rename v8.infinite_scroll benchmarks to archive old results. (Closed)
|
Created:
4 years, 5 months ago by ulan Modified:
4 years, 5 months ago Reviewers:
sullivan CC:
chromium-reviews, telemetry-reviews_chromium.org, Hannes Payer (out of office), Michael Lippautz, eakuefner Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRename v8.infinite_scroll benchmarks to archive old results.
In [1] we changed GC metrics to reduce noise and the number of results.
That change combines four old metrics into one new metric:
(Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name.
The dashboard currently takes more than 10 seconds to load all metrics in
the 'Subtest' dropdown list for v8.infinite_scroll.
This change renames the benchmarks so that we track only new metrics, but
still can access the old data.
[1]: https://github.com/catapult-project/catapult/issues/2444
BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/1c88977a803343e486b591443e8edc65b90c25fa
Cr-Commit-Position: refs/heads/master@{#403906}
Patch Set 1 #
Messages
Total messages: 19 (6 generated)
Description was changed from ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. The change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= ========== to ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. The change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. The change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. That change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
ulan@chromium.org changed reviewers: + sullivan@chromium.org
PTAL
+eakuefner FWIW, we can rename the old data on the dashboard if that makes more sense. I'm OOO this week, but Ethan can help out with that. Just let him know if you'd like to keep this CL or rename the old data.
On 2016/07/06 12:04:45, sullivan wrote: > +eakuefner > > FWIW, we can rename the old data on the dashboard if that makes more sense. I'm > OOO this week, but Ethan can help out with that. Just let him know if you'd like > to keep this CL or rename the old data. I'd like to keep the CL because there are 4x more old data than new data.
lgtm
The CQ bit was checked by ulan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
Message was sent while issue was closed.
Description was changed from ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. That change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. That change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. That change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Rename v8.infinite_scroll benchmarks to archive old results. In [1] we changed GC metrics to reduce noise and the number of results. That change combines four old metrics into one new metric: (Animation|Rail|Idle|Load)-gc-metric-name => gc-metric-name. The dashboard currently takes more than 10 seconds to load all metrics in the 'Subtest' dropdown list for v8.infinite_scroll. This change renames the benchmarks so that we track only new metrics, but still can access the old data. [1]: https://github.com/catapult-project/catapult/issues/2444 BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/1c88977a803343e486b591443e8edc65b90c25fa Cr-Commit-Position: refs/heads/master@{#403906} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1c88977a803343e486b591443e8edc65b90c25fa Cr-Commit-Position: refs/heads/master@{#403906} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
