Issue 212943003: android: Stop passing defines to apk-obfuscate.xml which it ignores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212943003: android: Stop passing defines to apk-obfuscate.xml which it ignores. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Stop passing defines to apk-obfuscate.xml which it ignores. Most of these are leftovers from when apk-obfuscate.xml was moved to its own file in https://chromiumcodereview.appspot.com/12880007 CREATE_TEST_JAR_PATH was removed in https://codereview.chromium.org/35473002 No intended behavior change. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260563

Patch Set 2 : more #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -71 lines)			Patch
	D	build/android/ant/create-test-jar.js	View	1	1 chunk	+0 lines, -65 lines	0 comments	Download
	M	build/java_apk.gypi	View	1	3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/212943003/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/212943003/diff/1/build/java_apk.gypi#newcode156 build/java_apk.gypi:156: 'apk_output_jar_path': '<(jar_path)', (jar_path is set to '<(PRODUCT_DIR)/lib.java/<(jar_name)', might as ...

6 years, 8 months ago (2014-03-29 04:10:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/212943003/20001

6 years, 8 months ago (2014-03-31 16:34:17 UTC) #4

Message was sent while issue was closed.

Change committed as 260563

Expand Messages | Collapse Messages

Issue 212943003: android: Stop passing defines to apk-obfuscate.xml which it ignores. (Closed)

Description

Patch Set 1 #

Patch Set 2 : more #

Messages