Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/extensions/component_extensions_whitelist/whitelist.h" | 5 #include "chrome/browser/extensions/component_extensions_whitelist/whitelist.h" |
| 6 | 6 |
| 7 #include <stddef.h> | 7 #include <stddef.h> |
| 8 | 8 |
| 9 #include "base/logging.h" | 9 #include "base/logging.h" |
| 10 #include "base/macros.h" | 10 #include "base/macros.h" |
| (...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 60 } | 60 } |
| 61 #endif | 61 #endif |
| 62 LOG(ERROR) << "Component extension with id " << extension_id << " not in " | 62 LOG(ERROR) << "Component extension with id " << extension_id << " not in " |
| 63 << "whitelist and is not being loaded as a result."; | 63 << "whitelist and is not being loaded as a result."; |
| 64 NOTREACHED(); | 64 NOTREACHED(); |
| 65 return false; | 65 return false; |
| 66 } | 66 } |
| 67 | 67 |
| 68 bool IsComponentExtensionWhitelisted(int manifest_resource_id) { | 68 bool IsComponentExtensionWhitelisted(int manifest_resource_id) { |
| 69 int allowed[] = { | 69 int allowed[] = { |
| 70 // Please keep the list in alphabetical order. | |
| 70 IDR_BOOKMARKS_MANIFEST, | 71 IDR_BOOKMARKS_MANIFEST, |
| 72 #if defined(ENABLE_APP_LIST) | |
| 71 IDR_CHROME_APP_MANIFEST, | 73 IDR_CHROME_APP_MANIFEST, |
| 74 #endif | |
| 72 IDR_CLOUDPRINT_MANIFEST, | 75 IDR_CLOUDPRINT_MANIFEST, |
| 73 IDR_CONNECTIVITY_DIAGNOSTICS_MANIFEST, | |
| 74 IDR_CRYPTOTOKEN_MANIFEST, | 76 IDR_CRYPTOTOKEN_MANIFEST, |
| 75 IDR_FEEDBACK_MANIFEST, | 77 IDR_FEEDBACK_MANIFEST, |
| 76 IDR_GAIA_AUTH_MANIFEST, | 78 IDR_GAIA_AUTH_MANIFEST, |
| 79 #if defined(ENABLE_GOOGLE_NOW) | |
| 77 IDR_GOOGLE_NOW_MANIFEST, | 80 IDR_GOOGLE_NOW_MANIFEST, |
| 81 #endif | |
| 82 #if defined(GOOGLE_CHROME_BUILD) || defined(ENABLE_HANGOUT_SERVICES_EXTENSION) | |
| 78 IDR_HANGOUT_SERVICES_MANIFEST, | 83 IDR_HANGOUT_SERVICES_MANIFEST, |
| 84 #endif | |
| 85 #if defined(ENABLE_HOTWORDING) | |
| 79 IDR_HOTWORD_AUDIO_VERIFICATION_MANIFEST, | 86 IDR_HOTWORD_AUDIO_VERIFICATION_MANIFEST, |
| 80 IDR_HOTWORD_MANIFEST, | 87 IDR_HOTWORD_MANIFEST, |
| 88 #endif | |
| 81 IDR_IDENTITY_API_SCOPE_APPROVAL_MANIFEST, | 89 IDR_IDENTITY_API_SCOPE_APPROVAL_MANIFEST, |
| 82 IDR_NETWORK_SPEECH_SYNTHESIS_MANIFEST, | |
| 83 IDR_SETTINGS_APP_MANIFEST, | |
| 84 IDR_WALLPAPERMANAGER_MANIFEST, | |
| 85 IDR_WEBSTORE_MANIFEST, | |
| 86 #if defined(IMAGE_LOADER_EXTENSION) | 90 #if defined(IMAGE_LOADER_EXTENSION) |
| 87 IDR_IMAGE_LOADER_MANIFEST, | 91 IDR_IMAGE_LOADER_MANIFEST, |
| 88 #endif | 92 #endif |
| 93 IDR_NETWORK_SPEECH_SYNTHESIS_MANIFEST, | |
| 94 #if defined(ENABLE_SETTINGS_APP) | |
| 95 IDR_SETTINGS_APP_MANIFEST, | |
| 96 #endif | |
| 97 IDR_WEBSTORE_MANIFEST, | |
| 98 | |
| 89 #if defined(OS_CHROMEOS) | 99 #if defined(OS_CHROMEOS) |
| 100 // Separate ChromeOS list, as it is quite large. | |
| 90 IDR_ARC_SUPPORT_MANIFEST, | 101 IDR_ARC_SUPPORT_MANIFEST, |
| 91 IDR_AUDIO_PLAYER_MANIFEST, | 102 IDR_AUDIO_PLAYER_MANIFEST, |
| 92 IDR_CHROME_APPS_WEBSTORE_WIDGET_MANIFEST, | 103 IDR_CHROME_APPS_WEBSTORE_WIDGET_MANIFEST, |
| 93 IDR_CONNECTIVITY_DIAGNOSTICS_LAUNCHER_MANIFEST, | 104 IDR_CONNECTIVITY_DIAGNOSTICS_LAUNCHER_MANIFEST, |
| 94 IDR_CONNECTIVITY_DIAGNOSTICS_MANIFEST, | 105 IDR_CONNECTIVITY_DIAGNOSTICS_MANIFEST, |
| 95 IDR_CROSH_BUILTIN_MANIFEST, | 106 IDR_CROSH_BUILTIN_MANIFEST, |
| 96 IDR_DEMO_APP_MANIFEST, | 107 IDR_DEMO_APP_MANIFEST, |
| 97 IDR_EASY_UNLOCK_MANIFEST, | 108 IDR_EASY_UNLOCK_MANIFEST, |
| 98 IDR_EASY_UNLOCK_MANIFEST_SIGNIN, | 109 IDR_EASY_UNLOCK_MANIFEST_SIGNIN, |
| 99 IDR_ECHO_MANIFEST, | 110 IDR_ECHO_MANIFEST, |
| 100 IDR_FILEMANAGER_MANIFEST, | 111 IDR_FILEMANAGER_MANIFEST, |
| 101 IDR_FIRST_RUN_DIALOG_MANIFEST, | 112 IDR_FIRST_RUN_DIALOG_MANIFEST, |
| 102 IDR_GALLERY_MANIFEST, | 113 IDR_GALLERY_MANIFEST, |
| 114 IDR_KEYBOARD_MANIFEST, | |
| 115 IDR_MOBILE_MANIFEST, | |
| 116 IDR_VIDEO_PLAYER_MANIFEST, | |
| 117 IDR_WALLPAPERMANAGER_MANIFEST, | |
| 118 #if defined(GOOGLE_CHROME_BUILD) | |
| 103 IDR_GENIUS_APP_MANIFEST, | 119 IDR_GENIUS_APP_MANIFEST, |
| 104 IDR_HELP_MANIFEST, | 120 IDR_HELP_MANIFEST, |
| 105 IDR_KEYBOARD_MANIFEST, | |
| 106 IDR_MOBILE_MANIFEST, | |
| 107 IDR_QUICKOFFICE_MANIFEST, | 121 IDR_QUICKOFFICE_MANIFEST, |
| 108 IDR_VIDEO_PLAYER_MANIFEST, | 122 #endif // defined(GOOGLE_CHROME_BUILD) |
| 109 IDR_WALLPAPERMANAGER_MANIFEST, | 123 #endif // defined(OS_CHROMEOS) |
| 110 #endif | |
| 111 }; | 124 }; |
| 112 | 125 |
| 113 for (size_t i = 0; i < arraysize(allowed); ++i) { | 126 for (size_t i = 0; i < arraysize(allowed); ++i) { |
|
Evan Stade
2016/07/15 18:29:31
nit: why doesn't this function employ a switch/cas
Lei Zhang
2016/07/16 00:35:50
Probably was a copy + paste from IsComponentExtens
| |
| 114 if (manifest_resource_id == allowed[i]) | 127 if (manifest_resource_id == allowed[i]) |
| 115 return true; | 128 return true; |
| 116 } | 129 } |
| 117 | 130 |
| 118 LOG(ERROR) << "Component extension with manifest resource id " | 131 LOG(ERROR) << "Component extension with manifest resource id " |
| 119 << manifest_resource_id << " not in whitelist and is not being " | 132 << manifest_resource_id << " not in whitelist and is not being " |
| 120 << "loaded as a result."; | 133 << "loaded as a result."; |
| 121 NOTREACHED(); | 134 NOTREACHED(); |
| 122 return false; | 135 return false; |
| 123 } | 136 } |
| 124 | 137 |
| 125 } // namespace extensions | 138 } // namespace extensions |
| OLD | NEW |