Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/app/theme/theme_resources.grd

Issue 2129413002: Use output_all_resource_defines=false in some chrome/ grd files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, address comment, more whitelist.cc cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/theme/chrome_unscaled_resources.grd ('k') | chrome/browser/browser_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- This grd file contains images that are pre-scaled for device scale 2 <!-- This grd file contains images that are pre-scaled for device scale
3 factors. The image returned by |base::ResourceBundle::GetImageNamed| 3 factors. The image returned by |base::ResourceBundle::GetImageNamed|
4 will contain multiple |gfx:ImageSkiaReps| for each scale factors. The 4 will contain multiple |gfx:ImageSkiaReps| for each scale factors. The
5 |fallback_to_low_resolution| attribute controls behavior when 5 |fallback_to_low_resolution| attribute controls behavior when
6 an image file is missing for target scale factor. If true, chrome 6 an image file is missing for target scale factor. If true, chrome
7 will automatically scale the 1x image to the target scale factor. 7 will automatically scale the 1x image to the target scale factor.
8 If false, build will fail due to missing resources. This is 8 If false, build will fail due to missing resources. This is
9 currently set to true for all resources, but the default will 9 currently set to true for all resources, but the default will
10 become false in near future. 10 become false in near future.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_LEFT" file="common/ash/browser_window_header_shade_left.png" /> 78 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_LEFT" file="common/ash/browser_window_header_shade_left.png" />
79 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_RIGHT" file="common/ash/browser_window_header_shade_right.png" /> 79 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_RIGHT" file="common/ash/browser_window_header_shade_right.png" />
80 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP" file="common/ash/browser_window_header_shade_top.png" /> 80 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP" file="common/ash/browser_window_header_shade_top.png" />
81 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP_LEFT" file="common/ash/browser_window_header_shade_top_left.png" /> 81 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP_LEFT" file="common/ash/browser_window_header_shade_top_left.png" />
82 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP_RIGHT" file="common/ash/browser_window_header_shade_top_right.png" / > 82 <structure type="chrome_scaled_image" name="IDR_ASH_BROWSER_WINDOW_HEADE R_SHADE_TOP_RIGHT" file="common/ash/browser_window_header_shade_top_right.png" / >
83 </if> 83 </if>
84 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N" file="common/autofill_dialog_menu_button_normal.png" /> 84 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N" file="common/autofill_dialog_menu_button_normal.png" />
85 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_P" file="common/autofill_dialog_menu_button_pressed.png" /> 85 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_P" file="common/autofill_dialog_menu_button_pressed.png" />
86 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_H" file="common/autofill_dialog_menu_button_hover.png" /> 86 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_H" file="common/autofill_dialog_menu_button_hover.png" />
87 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_D" file="common/autofill_dialog_menu_button_disabled.png" /> 87 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_DIALOG_MENU_BUTTO N_D" file="common/autofill_dialog_menu_button_disabled.png" />
88 <!-- TODO(jamescook): Update all Chrome platforms to use the new art and m etrics
89 from Ash, crbug.com/118228 -->
90 <if expr="toolkit_views or is_macosx or is_ios"> 88 <if expr="toolkit_views or is_macosx or is_ios">
91 <structure type="chrome_scaled_image" name="IDR_BACK" file="common/brows er_back_normal.png" /> 89 <structure type="chrome_scaled_image" name="IDR_BACK" file="common/brows er_back_normal.png" />
92 <structure type="chrome_scaled_image" name="IDR_BACK_D" file="common/bro wser_back_disabled.png" /> 90 <structure type="chrome_scaled_image" name="IDR_BACK_D" file="common/bro wser_back_disabled.png" />
93 <structure type="chrome_scaled_image" name="IDR_BACK_H" file="common/bro wser_back_hover.png" /> 91 <structure type="chrome_scaled_image" name="IDR_BACK_H" file="common/bro wser_back_hover.png" />
94 <structure type="chrome_scaled_image" name="IDR_BACK_P" file="common/bro wser_back_pressed.png" /> 92 <structure type="chrome_scaled_image" name="IDR_BACK_P" file="common/bro wser_back_pressed.png" />
95 </if> 93 </if>
96 <structure type="chrome_scaled_image" name="IDR_BLOCKED_BACKGROUND_SYNC" f ile="common/blocked_background_sync.png" /> 94 <structure type="chrome_scaled_image" name="IDR_BLOCKED_BACKGROUND_SYNC" f ile="common/blocked_background_sync.png" />
97 <structure type="chrome_scaled_image" name="IDR_BLOCKED_CAMERA" file="comm on/blocked_camera.png" /> 95 <structure type="chrome_scaled_image" name="IDR_BLOCKED_CAMERA" file="comm on/blocked_camera.png" />
98 <structure type="chrome_scaled_image" name="IDR_BLOCKED_COOKIES" file="com mon/blocked_cookies.png" /> 96 <structure type="chrome_scaled_image" name="IDR_BLOCKED_COOKIES" file="com mon/blocked_cookies.png" />
99 <structure type="chrome_scaled_image" name="IDR_BLOCKED_DOWNLOADS" file="c ommon/blocked_downloads.png" /> 97 <structure type="chrome_scaled_image" name="IDR_BLOCKED_DOWNLOADS" file="c ommon/blocked_downloads.png" />
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 <structure type="chrome_scaled_image" name="IDR_WEBSTORE_ICON_32" file=" google_chrome/webstore_icon_32.png" /> 927 <structure type="chrome_scaled_image" name="IDR_WEBSTORE_ICON_32" file=" google_chrome/webstore_icon_32.png" />
930 </if> 928 </if>
931 <if expr="is_macosx"> 929 <if expr="is_macosx">
932 <structure type="chrome_scaled_image" name="IDR_ZOOM_MINUS" file="legacy /zoom_minus.png" /> 930 <structure type="chrome_scaled_image" name="IDR_ZOOM_MINUS" file="legacy /zoom_minus.png" />
933 <structure type="chrome_scaled_image" name="IDR_ZOOM_PLUS" file="legacy/ zoom_plus.png" /> 931 <structure type="chrome_scaled_image" name="IDR_ZOOM_PLUS" file="legacy/ zoom_plus.png" />
934 <structure type="chrome_scaled_image" name="IDR_ZOOM_NORMAL" file="legac y/zoom_reset.png" /> 932 <structure type="chrome_scaled_image" name="IDR_ZOOM_NORMAL" file="legac y/zoom_reset.png" />
935 </if> 933 </if>
936 </structures> 934 </structures>
937 </release> 935 </release>
938 </grit> 936 </grit>
OLDNEW
« no previous file with comments | « chrome/app/theme/chrome_unscaled_resources.grd ('k') | chrome/browser/browser_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698