Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129373002: Replace all occurrences of words meaning "off the record" with "incognito" (Closed)

Created:
4 years, 5 months ago by Sungmann Cho
Modified:
4 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace all occurrences of words meaning "off the record" with "incognito" BUG=3333 TEST=None Committed: https://crrev.com/dc31a5a6214f0d99e4436c1a39cdd59db3725762 Cr-Commit-Position: refs/heads/master@{#404592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Sungmann Cho
Please take a look. Thanks!
4 years, 5 months ago (2016-07-09 09:59:57 UTC) #3
Peter Kasting
LGTM
4 years, 5 months ago (2016-07-11 01:35:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129373002/1
4 years, 5 months ago (2016-07-11 02:13:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 03:05:38 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 03:05:41 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 03:07:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc31a5a6214f0d99e4436c1a39cdd59db3725762
Cr-Commit-Position: refs/heads/master@{#404592}

Powered by Google App Engine
This is Rietveld 408576698