Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2129333002: Revert of Move the Syzygy scripts out of //chrome/ (Closed)

Created:
4 years, 5 months ago by Sébastien Marchand
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, gab, chrisha
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, grt+watch_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move the Syzygy scripts out of //chrome/ (patchset #5 id:80001 of https://codereview.chromium.org/2126673002/ ) Reason for revert: It's breaking the Gyp Official build and I can't fix this right now. BUG=626828 Original issue's description: > Move the Syzygy scripts out of //chrome/ > > Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome). > > BUG=619086 > > Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758 > Cr-Commit-Position: refs/heads/master@{#404503} TBR=chrisha@chromium.org,dpranke@chromium.org,gab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619086 Committed: https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb Cr-Commit-Position: refs/heads/master@{#404530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -470 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
D build/win/syzygy/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D build/win/syzygy/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D build/win/syzygy/instrument.py View 1 chunk +0 lines, -157 lines 0 comments Download
D build/win/syzygy/reorder.py View 1 chunk +0 lines, -111 lines 0 comments Download
D build/win/syzygy/syzyasan-allocation-filter.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D build/win/syzygy/syzyasan-instrumentation-filter.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D build/win/syzygy/syzygy.gni View 1 chunk +0 lines, -137 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/syzygy/BUILD.gn View 6 chunks +155 lines, -9 lines 0 comments Download
A chrome/tools/build/win/syzygy/instrument.py View 1 chunk +157 lines, -0 lines 0 comments Download
A chrome/tools/build/win/syzygy/reorder.py View 1 chunk +111 lines, -0 lines 0 comments Download
A chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/tools/build/win/syzygy/syzyasan-instrumentation-filter.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/kasko/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sébastien Marchand
Created Revert of Move the Syzygy scripts out of //chrome/
4 years, 5 months ago (2016-07-08 23:25:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129333002/1
4 years, 5 months ago (2016-07-08 23:25:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:26:38 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 23:26:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb Cr-Commit-Position: refs/heads/master@{#404530}
4 years, 5 months ago (2016-07-08 23:28:01 UTC) #8
Dirk Pranke
4 years, 5 months ago (2016-07-09 00:38:58 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698