Oilpan: turn DOMWindow into a heap supplementable.

Source/core/page/DOMWindowPagePopup.h

Index: Source/core/page/DOMWindowPagePopup.h
diff --git a/Source/core/page/DOMWindowPagePopup.h b/Source/core/page/DOMWindowPagePopup.h
index 9209eb309c253633d544e013bd054b9e41727d6b..0834a42946759c7fe752b13105e743b1a0ab7a3b 100644
--- a/Source/core/page/DOMWindowPagePopup.h
+++ b/Source/core/page/DOMWindowPagePopup.h
@@ -40,18 +40,21 @@ class DOMWindow;
 class PagePopupClient;
 class PagePopupController;
 
-class DOMWindowPagePopup FINAL : public Supplement<DOMWindow> {
+class DOMWindowPagePopup FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowPagePopup>, public WillBeHeapSupplement<DOMWindow> {

[sof, 2014/03/26 19:28:29]

I don't think this needs to be *Finalizable, but the GC plugin insists that no
destructor should be present if so. That looks unsafe for the non-Oilpan case,
so I fell back to using *Finalizable.

[haraken, 2014/03/27 00:59:03]

You can use DECLARE_EMPTY_VIRTUAL_DESTROCTOR and DEFINE_EMPTY_DESTRUCTOR, and
then make it NoBaseWillBeGarbageCollected.

[sof, 2014/03/27 07:25:51]

Ah - switched, thanks. (I wasn't aware that had been added recently as I'm not
seeing oilpan-reviews traffic.)

+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowPagePopup);
 public:
     static PagePopupController* pagePopupController(DOMWindow&);
     static void install(DOMWindow&, PagePopupClient*);
     static void uninstall(DOMWindow&);
     virtual ~DOMWindowPagePopup();
 
+    void trace(Visitor*);
+
 private:
     explicit DOMWindowPagePopup(PagePopupClient*);
     static const char* supplementName();
 
-    RefPtrWillBePersistent<PagePopupController> m_controller;
+    RefPtrWillBeMember<PagePopupController> m_controller;
 };
 
 }