Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: Source/modules/speech/DOMWindowSpeechSynthesis.h

Issue 212933005: Oilpan: turn DOMWindow into a heap supplementable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 17 matching lines...) Expand all
28 28
29 #include "core/frame/DOMWindowProperty.h" 29 #include "core/frame/DOMWindowProperty.h"
30 #include "heap/Handle.h" 30 #include "heap/Handle.h"
31 #include "modules/speech/SpeechSynthesis.h" 31 #include "modules/speech/SpeechSynthesis.h"
32 #include "platform/Supplementable.h" 32 #include "platform/Supplementable.h"
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 class DOMWindow; 36 class DOMWindow;
37 37
38 class DOMWindowSpeechSynthesis FINAL : public Supplement<DOMWindow>, public DOMW indowProperty { 38 class DOMWindowSpeechSynthesis FINAL : public NoBaseWillBeGarbageCollectedFinali zed<DOMWindowSpeechSynthesis>, public WillBeHeapSupplement<DOMWindow>, public DO MWindowProperty {
haraken 2014/03/27 00:59:03 Ditto.
sof 2014/03/27 07:25:51 I think we need to consider changing DOMWindowProp
39 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowSpeechSynthesis);
39 public: 40 public:
40 virtual ~DOMWindowSpeechSynthesis(); 41 virtual ~DOMWindowSpeechSynthesis();
41 42
42 static SpeechSynthesis* speechSynthesis(DOMWindow&); 43 static SpeechSynthesis* speechSynthesis(DOMWindow&);
43 static DOMWindowSpeechSynthesis& from(DOMWindow&); 44 static DOMWindowSpeechSynthesis& from(DOMWindow&);
44 45
46 void trace(Visitor*);
47
45 private: 48 private:
46 explicit DOMWindowSpeechSynthesis(DOMWindow&); 49 explicit DOMWindowSpeechSynthesis(DOMWindow&);
47 50
48 SpeechSynthesis* speechSynthesis(); 51 SpeechSynthesis* speechSynthesis();
49 static const char* supplementName(); 52 static const char* supplementName();
50 53
51 RefPtrWillBePersistent<SpeechSynthesis> m_speechSynthesis; 54 RefPtrWillBeMember<SpeechSynthesis> m_speechSynthesis;
52 }; 55 };
53 56
54 } // namespace WebCore 57 } // namespace WebCore
55 58
56 #endif // DOMWindowSpeechSynthesis_h 59 #endif // DOMWindowSpeechSynthesis_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698