Oilpan: turn DOMWindow into a heap supplementable.

Source/core/page/DOMWindowPagePopup.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 
 #include "heap/Handle.h"
 #include "platform/Supplementable.h"
 
 namespace WebCore {
 
 class DOMWindow;
 class PagePopupClient;
 class PagePopupController;
 
-class DOMWindowPagePopup FINAL : public Supplement<DOMWindow> {
+class DOMWindowPagePopup FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowPagePopup>, public WillBeHeapSupplement<DOMWindow> {

[sof, 2014/03/26 19:28:29]

I don't think this needs to be *Finalizable, but the GC plugin insists that no
destructor should be present if so. That looks unsafe for the non-Oilpan case,
so I fell back to using *Finalizable.

[haraken, 2014/03/27 00:59:03]

You can use DECLARE_EMPTY_VIRTUAL_DESTROCTOR and DEFINE_EMPTY_DESTRUCTOR, and
then make it NoBaseWillBeGarbageCollected.

[sof, 2014/03/27 07:25:51]

Ah - switched, thanks. (I wasn't aware that had been added recently as I'm not
seeing oilpan-reviews traffic.)

+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMWindowPagePopup);
 public:
     static PagePopupController* pagePopupController(DOMWindow&);
     static void install(DOMWindow&, PagePopupClient*);
     static void uninstall(DOMWindow&);
     virtual ~DOMWindowPagePopup();
 
+    void trace(Visitor*);
+
 private:
     explicit DOMWindowPagePopup(PagePopupClient*);
     static const char* supplementName();
 
-    RefPtrWillBePersistent<PagePopupController> m_controller;
+    RefPtrWillBeMember<PagePopupController> m_controller;
 };
 
 }
 #endif