Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/public/browser/geolocation_delegate.h

Issue 2129313002: Geolocation cleanup: corrects uses of content::AccessTokenStore* and net::URLRequestContextGetter* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed StartTestStepFromClientThread() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/access_token_store.h ('k') | content/public/browser/geolocation_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/geolocation_delegate.h
diff --git a/content/public/browser/geolocation_delegate.h b/content/public/browser/geolocation_delegate.h
index 0e94c01ae78803938e1f45b5b57f4b86e889e559..36ff280a815387a560553228832e4d0bf6069632 100644
--- a/content/public/browser/geolocation_delegate.h
+++ b/content/public/browser/geolocation_delegate.h
@@ -7,6 +7,7 @@
#include <memory>
+#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
namespace content {
@@ -24,9 +25,7 @@ class CONTENT_EXPORT GeolocationDelegate {
virtual bool UseNetworkLocationProviders();
// Creates a new AccessTokenStore for geolocation. May return nullptr.
- // TODO(mcasas): consider changing it return type to std::unique_ptr<> to
- // clarify ownership, https://crbug.com/623114.
- virtual AccessTokenStore* CreateAccessTokenStore();
+ virtual scoped_refptr<AccessTokenStore> CreateAccessTokenStore();
// Allows an embedder to return its own LocationProvider implementation.
// Return nullptr to use the default one for the platform to be created.
« no previous file with comments | « content/public/browser/access_token_store.h ('k') | content/public/browser/geolocation_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698