Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129293002: [Payments] Update autofill/payments spacings (Closed)

Created:
4 years, 5 months ago by gone
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Payments] Update autofill/payments spacings * The fields felt a little squished. Try to space them out a little better. * Update the underline colors to match the TextInputLayers. * Add support for half width controls in the display. Screenshots here: https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190 BUG=603635, 626451 TBR=rouslan,ianwen Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce Review-Url: https://codereview.chromium.org/2114493002 Cr-Original-Commit-Position: refs/heads/master@{#404241} Cr-Commit-Position: refs/heads/master@{#404446} Committed: https://chromium.googlesource.com/chromium/src/+/29dd8f9bb484090f141f855cd96c3d4c8b9af771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -139 lines) Patch
M chrome/android/java/res/layout/autofill_billing_address_dropdown.xml View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/autofill_local_card_editor.xml View 5 chunks +27 lines, -14 lines 0 comments Download
M chrome/android/java/res/layout/autofill_profile_editor.xml View 3 chunks +14 lines, -27 lines 0 comments Download
M chrome/android/java/res/layout/autofill_server_card_editor.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/payment_request_editor.xml View 1 chunk +3 lines, -14 lines 0 comments Download
A chrome/android/java/res/layout/payment_request_editor_dropdown.xml View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/payment_request_editor_footer.xml View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/preference_address_float_label_layout.xml View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 6 chunks +16 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 8 chunks +103 lines, -48 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 4 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
gone
4 years, 5 months ago (2016-07-08 20:05:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
29dd8f9bb484090f141f855cd96c3d4c8b9af771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698