sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart - Issue 212923006: Rationalize arg handling for pub build and serve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart

Issue 212923006: Rationalize arg handling for pub build and serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Revise. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/barback/fails_if_args_with_all_test.dart ('k') | sdk/lib/_internal/pub/test/barback/fails_if_dir_outside_package_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart

diff --git a/sdk/lib/_internal/pub/test/serve/serves_index_html_for_directories_test.dart b/sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart

similarity index 51%

copy from sdk/lib/_internal/pub/test/serve/serves_index_html_for_directories_test.dart

copy to sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart

index 0974381601f7ea439833769314dfcaafb1fb40af..f32d626cb9eb3ed962db03865252d9b8d1b6a0a8 100644

--- a/sdk/lib/_internal/pub/test/serve/serves_index_html_for_directories_test.dart

+++ b/sdk/lib/_internal/pub/test/barback/fails_if_dir_arg_does_not_exist_test.dart

@@ -2,29 +2,28 @@

// BSD-style license that can be found in the LICENSE file.

-library pub_tests;

+import 'package:scheduled_test/scheduled_test.dart';

+import '../../lib/src/exit_codes.dart' as exit_codes;

import '../descriptor.dart' as d;

import '../test_pub.dart';

import 'utils.dart';

main() {

initConfig();

- integration("serves index.html for directories", () {

+ setUp(() {

d.dir(appPath, [

d.appPubspec(),

- d.dir("web", [

- d.file("index.html", "<body>super"),

- d.dir("sub", [

- d.file("index.html", "<body>sub")

- ])

+ d.dir("bar", [

+ d.file("file.txt", "contents")

])

]).create();

- pubServe();

- requestShouldSucceed("", "<body>super");

- requestShouldSucceed("sub/", "<body>sub");

- requestShouldRedirect("sub", "/sub/");

- endPubServe();

});

+ pubBuildAndServeShouldFail("if a specified directory doesn't exist",

+ args: ["foo", "bar", "baz"],

+ error: 'Directories "foo" and "baz" do not exist.',

+ exitCode: exit_codes.DATA);

}