Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart

Issue 212923006: Rationalize arg handling for pub build and serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/command/barback.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart b/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart
index cecf94002ced6dad7691f48c94ed032b0c4316d0..5af3b5c2b34aae3a20eed117b4e2e4d1d7e41f71 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart
@@ -60,8 +60,9 @@ class Dart2JSTransformer extends Transformer implements LazyTransformer {
Future<bool> isPrimary(Asset asset) {
if (asset.id.extension != ".dart") return new Future.value(false);
- if (!["benchmark", "example", "test", "web"]
- .any((dir) => asset.id.path.startsWith("$dir/"))) {
+ // These should only contain libraries. For efficiency's sake, we don't
+ // look for entrypoints in there.
+ if (["asset/", "lib/"].any(asset.id.path.startsWith)) {
return new Future.value(false);
}
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/command/barback.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698