Rationalize arg handling for pub build and serve.

sdk/lib/_internal/pub/lib/src/command/build.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.command.build;
 
 import 'dart:async';
 
 import 'package:barback/barback.dart';
 import 'package:path/path.dart' as path;
 
 import '../barback/build_environment.dart';
-import '../command.dart';
 import '../exit_codes.dart' as exit_codes;
 import '../io.dart';
 import '../log.dart' as log;
 import '../utils.dart';
+import 'barback.dart';
 
 final _arrow = getSpecial('\u2192', '=>');
 
-/// The set of top level directories in the entrypoint package that can be
-/// built.
-final _allowedBuildDirectories = new Set<String>.from([
-  "benchmark", "bin", "example", "test", "web"
-]);
-
 /// Handles the `build` pub command.
-class BuildCommand extends PubCommand {
+class BuildCommand extends BarbackCommand {
   String get description => "Apply transformers to build a package.";
   String get usage => "pub build [options] [directories...]";
   List<String> get aliases => const ["deploy", "settle-up"];
-  bool get takesArguments => true;
 
   // TODO(nweiz): make this configurable.
   /// The path to the application's build output directory.
   String get target => 'build';
 
-  /// The build mode.
-  BarbackMode get mode => new BarbackMode(commandOptions["mode"]);
+  BarbackMode get defaultMode => BarbackMode.RELEASE;
+
+  List<String> get defaultSourceDirectories => ["web"];
 
   /// The number of files that have been built and written to disc so far.
   int builtFiles = 0;
 
-  /// The names of the top-level build directories that will be built.
-  final buildDirectories = new Set<String>();
-
   BuildCommand() {
     commandParser.addOption("format",
         help: "How output should be displayed.",
         allowed: ["text", "json"], defaultsTo: "text");
-
-    commandParser.addOption("mode", defaultsTo: BarbackMode.RELEASE.toString(),
-        help: "Mode to run transformers in.");
-
-    commandParser.addFlag("all", help: "Build all buildable directories.",
-        defaultsTo: false, negatable: false);
   }
 
-  Future onRun() {
-    log.json.enabled = commandOptions["format"] == "json";
-
-    _parseBuildDirectories();
+  Future onRunTransformerCommand() {
     cleanDir(target);
 
     var errorsJson = [];
     var logJson = [];
 
     // Since this server will only be hit by the transformer loader and isn't
     // user-facing, just use an IPv4 address to avoid a weird bug on the
     // OS X buildbots.
     return BuildEnvironment.create(entrypoint, "127.0.0.1", 0, mode,
         WatcherType.NONE, useDart2JS: true)
@@ skipping 17 matching lines @@
       if (log.json.enabled) {
         environment.barback.log.listen(
             (entry) => logJson.add(_logEntryToJson(entry)));
       }
 
       return log.progress("Building ${entrypoint.root.name}", () {
         // Register all of the build directories.
         // TODO(rnystrom): We don't actually need to bind servers for these, we
         // just need to add them to barback's sources. Add support to
         // BuildEnvironment for going the latter without the former.
-        return Future.wait(buildDirectories.map(
+        return Future.wait(sourceDirectories.map(
             (dir) => environment.serveDirectory(dir))).then((_) {
 
           return environment.barback.getAllAssets();
         });
       }).then((assets) {
         // Find all of the JS entrypoints we built.
         var dart2JSEntrypoints = assets
             .where((asset) => asset.id.path.endsWith(".dart.js"))
             .map((asset) => asset.id);
 
@@ skipping 19 matching lines @@
       log.json.message({
         "buildResult": "failure",
         "errors": errorsJson,
         "log": logJson
       });
 
       return flushThenExit(exit_codes.DATA);
     });
   }
 
-  /// Parses the command-line arguments to determine the set of top-level
-  /// directories to build.
-  ///
-  /// If there are no arguments to `pub build`, this will just be "web".
-  ///
-  /// If the `--all` flag is set, then it will be all buildable directories
-  /// that exist.
-  ///
-  /// Otherwise, all arguments should be the names of directories to include.
-  ///
-  /// Throws an exception if the arguments are invalid.
-  void _parseBuildDirectories() {
-    if (commandOptions["all"]) {
-      if (commandOptions.rest.isNotEmpty) {
-        usageError(
-            'Build directory names are not allowed if "--all" is passed.');
-      }
-
-      // Include every build directory that exists in the package.
-      var allowed = _allowedBuildDirectories.where(
-          (d) => dirExists(path.join(entrypoint.root.dir, d)));
-
-      if (allowed.isEmpty) {
-        var buildDirs = toSentence(ordered(_allowedBuildDirectories.map(
-            (name) => '"$name"')));
-        dataError('There are no buildable directories.\n'
-                  'The supported directories are $buildDirs.');
-      }
-
-      buildDirectories.addAll(allowed);
-      return;
-    }
-
-    buildDirectories.addAll(commandOptions.rest);
-
-    // If no directory were specified, default to "web".
-    if (buildDirectories.isEmpty) {
-      buildDirectories.add("web");
-    }
-
-    // Make sure the arguments are known directories.
-    var disallowed = buildDirectories.where(
-        (dir) => !_allowedBuildDirectories.contains(dir));
-    if (disallowed.isNotEmpty) {
-      var dirs = pluralize("directory", disallowed.length,
-          plural: "directories");
-      var names = toSentence(ordered(disallowed).map((name) => '"$name"'));
-      var allowed = toSentence(ordered(_allowedBuildDirectories.map(
-          (name) => '"$name"')));
-      usageError('Unsupported build $dirs $names.\n'
-                 'The allowed directories are $allowed.');
-    }
-
-    // Make sure all of the build directories exist.
-    var missing = buildDirectories.where(
-        (dir) => !dirExists(path.join(entrypoint.root.dir, dir)));
-
-    if (missing.length == 1) {
-      dataError('Directory "${missing.single}" does not exist.');
-    } else if (missing.isNotEmpty) {
-      var names = toSentence(ordered(missing).map((name) => '"$name"'));
-      dataError('Directories $names do not exist.');
-    }
-  }
-
   /// Writes [asset] to the appropriate build directory.
   ///
   /// If [asset] is in the special "assets" directory, writes it to every
   /// build directory.
   Future _writeAsset(Asset asset) {
     // In release mode, strip out .dart files since all relevant ones have been
     // compiled to JavaScript already.
     if (mode == BarbackMode.RELEASE && asset.id.extension == ".dart") {
       return new Future.value();
     }
 
     var destPath = _idtoPath(asset.id);
 
     // If the asset is from a public directory, copy it into all of the
     // top-level build directories.
     if (path.isWithin("assets", destPath) ||
         path.isWithin("packages", destPath)) {
-      return Future.wait(buildDirectories.map((buildDir) =>
+      return Future.wait(sourceDirectories.map((buildDir) =>
           _writeOutputFile(asset, path.join(buildDir, destPath))));
     }
 
     return _writeOutputFile(asset, destPath);
   }
 
   /// Converts [id] to a relative path in the output directory for that asset.
   ///
   /// This corresponds to the URL that could be used to request that asset from
   /// pub serve.
@@ skipping 119 matching lines @@
         "end": {
           "line": entry.span.end.line,
           "column": entry.span.end.column
         },
       };
     }
 
     return data;
   }
 }