Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
212923005:
Do not squash invisible layers. (Closed)
|
Created:
6 years, 9 months ago by Ian Vollick Modified:
6 years, 9 months ago Reviewers:
abarth-chromium CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionDo not squash invisible layers.
We used to squash RenderLayers even if they reported that
subtreeIsInvisible. This caused the creation of needlessly enormous
layers that contained nothing. This CL excludes those layers from
the list of squashed layers.
R=abarth@chromium.org
BUG=None
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170250
Patch Set 1 #Patch Set 2 : Updated TestExpectations #Patch Set 3 : Updated assertion in compositing reason finder. #Patch Set 4 : Avoid mucking with canBeComposited #
Messages
Total messages: 43 (0 generated)
LGTM
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
On 2014/03/26 20:12:43, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > tryserver.blink on win_blink_rel Turns out this cl broke a layout test that was counting on the presence of the invisible layers in the graphics layer tree dump. This appears unnecessary since the invisible GraphcisLayers don't change the output, so I've updated TestExpectations. Adam, slgty?
lgtm
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/40001
The CQ bit was unchecked by vollick@chromium.org
The CQ bit was checked by vollick@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
On 2014/03/27 19:57:48, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > tryserver.blink on linux_blink_dbg It turns out the changing canBeComposited has deeper side effects than I expected. I've made the visibility checks more localized. Could you please take another look, Adam?
lgtm
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by vollick@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/212923005/60001
Message was sent while issue was closed.
Change committed as 170250 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
