[ash-md] Hides frame headers in overview mode not using a mask

ash/common/wm/overview/scoped_transform_overview_window.h

Index: ash/common/wm/overview/scoped_transform_overview_window.h
diff --git a/ash/common/wm/overview/scoped_transform_overview_window.h b/ash/common/wm/overview/scoped_transform_overview_window.h
index 7445d763f4097810fc76ba9706b1b64937c2522e..8749a74635c6d2f811b790dc50659e4aecc11894 100644
--- a/ash/common/wm/overview/scoped_transform_overview_window.h
+++ b/ash/common/wm/overview/scoped_transform_overview_window.h
@@ -15,6 +15,8 @@
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/transform.h"
 
+class SkRegion;
+
 namespace gfx {
 class Rect;
 }
@@ -106,7 +108,7 @@ class ASH_EXPORT ScopedTransformOverviewWindow {
   // using rounded corners of |radius|.
   void SetTransform(WmWindow* root_window,
                     const gfx::Transform& transform,
-                    int radius);
+                    float radius);
 
   // Set's the opacity of the managed windows.
   void SetOpacity(float opacity);
@@ -135,6 +137,12 @@ class ASH_EXPORT ScopedTransformOverviewWindow {
   // Mask layer that hides the original window header.
   std::unique_ptr<OverviewContentMask> mask_;
 
+  // Original window shape.

[tdanderson, 2016/07/09 21:23:21]

From line 416 in scoped_transform_overview_window.cc, it looks like not every
window has an alpha shape. Can you modify the comments on line 140 and 143
accordingly? e.g., "The original window shape, if one exists" and "True after
the shape has been set, or after we determine that the window had no shape" or
something.

[varkha, 2016/07/09 22:00:17]

Done.

+  std::unique_ptr<SkRegion> original_alpha_shape_;

[tdanderson, 2016/07/09 21:23:21]

Maybe it's just because "alpha shape" is new terminology to me, but I think this
would be more readable if it were called |original_window_shape_|.

[varkha, 2016/07/09 22:00:17]

Done.

+
+  // True after |original_alpha_shape_| has been set.
+  bool alpha_shape_set_;

[tdanderson, 2016/07/09 21:23:21]

I don't think you need this (see my comments below), but if you do, rename to
|original_alpha_shape_set_| (or |original_window_shape_set_| if you change the
other member's name).

[varkha, 2016/07/09 22:00:17]

Done.

+
   // If true, the window was minimized and should be restored if the window
   // was not selected.
   bool minimized_;