[ash-md] Hides frame headers in overview mode not using a mask

chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h"
 
 #include <algorithm>
 
 #include "ash/common/ash_layout_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
@@ skipping 336 matching lines @@
   // size changes.
   if (browser_view()->initialized() && (child == caption_button_container_)) {
     InvalidateLayout();
     frame()->GetRootView()->Layout();
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // ash::ShellObserver:
 
 void BrowserNonClientFrameViewAsh::OnOverviewModeStarting() {

[tdanderson, 2016/07/08 18:51:55]

As a side question, why aren't we making any MD changes to BNCFVMus?

[varkha, 2016/07/08 19:27:41]

Good question, I will follow up with sky if it is expected at this stage.

-  if (ash::MaterialDesignController::IsOverviewMaterial())
+  if (!ash::MaterialDesignController::IsOverviewMaterial())
+    return;
+  if (browser_view()->IsTabStripVisible())
     caption_button_container_->SetVisible(false);
+  else
+    SetVisible(false);

[tdanderson, 2016/07/08 18:51:55]

Correct me if I'm mistaken, but isn't this setting *all* of the non-client areas
to be invisible, including the entire window border? Is that what we want to be
doing?

[varkha, 2016/07/08 19:27:41]

For ash browser frame this is the only visible portion at the moment, no (at
least in the borders that we use to scale the overview)?

 }
 
 void BrowserNonClientFrameViewAsh::OnOverviewModeEnded() {
-  if (ash::MaterialDesignController::IsOverviewMaterial())
+  if (!ash::MaterialDesignController::IsOverviewMaterial())
+    return;
+  if (browser_view()->IsTabStripVisible())
     caption_button_container_->SetVisible(true);
+  else
+    SetVisible(true);
 }
 
 void BrowserNonClientFrameViewAsh::OnMaximizeModeStarted() {
   caption_button_container_->UpdateSizeButtonVisibility();
   InvalidateLayout();
   frame()->client_view()->InvalidateLayout();
   frame()->GetRootView()->Layout();
 }
 
 void BrowserNonClientFrameViewAsh::OnMaximizeModeEnded() {
@@ skipping 210 matching lines @@
     // TODO(pkasting): The "2 *" part of this makes no sense to me.
     canvas->TileImageInt(*right, 0, 0, w - (2 * kClientEdgeThickness) - img_w,
                          img_y, img_w, img_h);
 
     // Toolbar/content separator.
     toolbar_bounds.Inset(kClientEdgeThickness, h - kClientEdgeThickness,
                          kClientEdgeThickness, 0);
     canvas->FillRect(toolbar_bounds, separator_color);
   }
 }