Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: build/common.gypi

Issue 2129213002: clang/win: It's ok to pass /GS to clang-cl now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7120836c637e8683adddc516c84a9f7cc9ae7a6e..cbc5e29fef4336934cd5daf024bc02b406cec348 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5702,6 +5702,7 @@
'VCCLCompilerTool': {
'AdditionalOptions': ['/MP'],
'MinimalRebuild': 'false',
+ 'BufferSecurityCheck': 'true',
'EnableFunctionLevelLinking': 'true',
'RuntimeTypeInfo': 'false',
'WarningLevel': '4',
@@ -5774,14 +5775,6 @@
}],
],
'conditions': [
- ['clang==0', {
- 'VCCLCompilerTool': {
- # TODO(thakis): Enable this with clang too,
- # https://crbug.com/598767
- 'BufferSecurityCheck': 'true',
- },
- }],
-
# Building with Clang on Windows is a work in progress and very
# experimental. See crbug.com/82385.
# Keep this in sync with the similar blocks in build/config/compiler/BUILD.gn
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698