clang/win: It's ok to pass /GS to clang-cl now.

clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
Committed: https://crrev.com/cc683aecb8e88d03139477b8eba81aeb1e3c2e9c
Cr-Commit-Position: refs/heads/master@{#404413}

[Nico, 2016-07-08 15:27:15]

Description was changed from

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary.

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
==========

to

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
==========

[Nico, 2016-07-08 15:27:25]

thakis@chromium.org changed reviewers:
+ etienneb@chromium.org

[etienneb, 2016-07-08 15:52:09]

lgtm

thx nico

[Nico, 2016-07-08 16:37:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-08 16:38:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 16:47:25]

Description was changed from

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
==========

to

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
==========

[commit-bot: I haz the power, 2016-07-08 16:47:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 16:49:21]

Description was changed from

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767
==========

to

==========
clang/win: It's ok to pass /GS to clang-cl now.

We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored.  Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/

/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.

Since /GS is on by default, this CL doesn't change behavior.

BUG=598767

Committed: https://crrev.com/cc683aecb8e88d03139477b8eba81aeb1e3c2e9c
Cr-Commit-Position: refs/heads/master@{#404413}
==========

[commit-bot: I haz the power, 2016-07-08 16:49:21]

Patchset 1 (id:??) landed as
https://crrev.com/cc683aecb8e88d03139477b8eba81aeb1e3c2e9c
Cr-Commit-Position: refs/heads/master@{#404413}