Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 21292003: Handle int/double case expression types correctly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * The messages in this file should meet the following guide lines: 8 * The messages in this file should meet the following guide lines:
9 * 9 *
10 * 1. The message should start with exactly one of "Error", "Internal error", 10 * 1. The message should start with exactly one of "Error", "Internal error",
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 static const MessageKind TYPE_VARIABLE_IN_CONSTANT = const MessageKind( 319 static const MessageKind TYPE_VARIABLE_IN_CONSTANT = const MessageKind(
320 'Error: Cannot refer to type variable in constant.'); 320 'Error: Cannot refer to type variable in constant.');
321 321
322 static const MessageKind INVALID_USE_OF_SUPER = const MessageKind( 322 static const MessageKind INVALID_USE_OF_SUPER = const MessageKind(
323 'Error: "super" not allowed here.'); 323 'Error: "super" not allowed here.');
324 324
325 static const MessageKind INVALID_CASE_DEFAULT = const MessageKind( 325 static const MessageKind INVALID_CASE_DEFAULT = const MessageKind(
326 'Error: "default" only allowed on last case of a switch.'); 326 'Error: "default" only allowed on last case of a switch.');
327 327
328 static const MessageKind SWITCH_CASE_TYPES_NOT_EQUAL = const MessageKind( 328 static const MessageKind SWITCH_CASE_TYPES_NOT_EQUAL = const MessageKind(
329 'Error: "case" expressions do not all have the same type.'); 329 'Error: "case" expressions do not all have type "#{type}".');
330
331 static const MessageKind SWITCH_CASE_TYPES_NOT_EQUAL_CASE = const MessageKind(
332 'Info: "case" expression of type "#{type}".');
330 333
331 static const MessageKind SWITCH_CASE_VALUE_OVERRIDES_EQUALS = 334 static const MessageKind SWITCH_CASE_VALUE_OVERRIDES_EQUALS =
332 const MessageKind( 335 const MessageKind(
333 'Error: "case" expression value overrides "operator==".'); 336 'Error: "case" expression value overrides "operator==".');
334 337
335 static const MessageKind INVALID_ARGUMENT_AFTER_NAMED = const MessageKind( 338 static const MessageKind INVALID_ARGUMENT_AFTER_NAMED = const MessageKind(
336 'Error: Unnamed argument after named argument.'); 339 'Error: Unnamed argument after named argument.');
337 340
338 static const MessageKind NOT_A_COMPILE_TIME_CONSTANT = const MessageKind( 341 static const MessageKind NOT_A_COMPILE_TIME_CONSTANT = const MessageKind(
339 'Error: Not a compile-time constant.'); 342 'Error: Not a compile-time constant.');
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 815
813 class CompileTimeConstantError extends Diagnostic { 816 class CompileTimeConstantError extends Diagnostic {
814 CompileTimeConstantError(MessageKind kind, [Map arguments = const {}]) 817 CompileTimeConstantError(MessageKind kind, [Map arguments = const {}])
815 : super(kind, arguments); 818 : super(kind, arguments);
816 } 819 }
817 820
818 class CompilationError extends Diagnostic { 821 class CompilationError extends Diagnostic {
819 CompilationError(MessageKind kind, [Map arguments = const {}]) 822 CompilationError(MessageKind kind, [Map arguments = const {}])
820 : super(kind, arguments); 823 : super(kind, arguments);
821 } 824 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/typechecker.dart ('k') | tests/compiler/dart2js/type_checker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698