Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/keys.h

Issue 2129193003: [keys] propagate PropertyFilter to proxy targets in KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add tests from the bug Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/keys.cc » ('j') | src/keys.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/keys.h
diff --git a/src/keys.h b/src/keys.h
index ecd3d97c550cf5a8aa80f2aa312c18d1001115ca..8206148840467b76a5a84f3ce449da2f86345492 100644
--- a/src/keys.h
+++ b/src/keys.h
@@ -43,8 +43,9 @@ class KeyAccumulator final BASE_EMBEDDED {
Handle<FixedArray> GetKeys(
GetKeysConversion convert = GetKeysConversion::kKeepNumbers);
- Maybe<bool> CollectKeys(Handle<JSReceiver> receiver,
- Handle<JSReceiver> object);
+ Maybe<bool> CollectKeys(
+ Handle<JSReceiver> receiver, Handle<JSReceiver> object,
+ GetKeysConversion keys_conversion = GetKeysConversion::kKeepNumbers);
Maybe<bool> CollectOwnElementIndices(Handle<JSReceiver> receiver,
Handle<JSObject> object);
Maybe<bool> CollectOwnPropertyNames(Handle<JSReceiver> receiver,
@@ -90,9 +91,11 @@ class KeyAccumulator final BASE_EMBEDDED {
Maybe<bool> CollectOwnKeys(Handle<JSReceiver> receiver,
Handle<JSObject> object);
Maybe<bool> CollectOwnJSProxyKeys(Handle<JSReceiver> receiver,
- Handle<JSProxy> proxy);
+ Handle<JSProxy> proxy,
+ GetKeysConversion keys_conversion);
Maybe<bool> CollectOwnJSProxyTargetKeys(Handle<JSProxy> proxy,
- Handle<JSReceiver> target);
+ Handle<JSReceiver> target,
+ GetKeysConversion keys_conversion);
Maybe<bool> AddKeysFromJSProxy(Handle<JSProxy> proxy,
Handle<FixedArray> keys);
bool IsShadowed(Handle<Object> key);
« no previous file with comments | « no previous file | src/keys.cc » ('j') | src/keys.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698