Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/keys.cc

Issue 2129193003: [keys] propagate PropertyFilter to proxy targets in KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: just hardcode kConvertToStrings for proxy targets Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/keys.h" 5 #include "src/keys.h"
6 6
7 #include "src/api-arguments.h" 7 #include "src/api-arguments.h"
8 #include "src/elements.h" 8 #include "src/elements.h"
9 #include "src/factory.h" 9 #include "src/factory.h"
10 #include "src/identity-map.h" 10 #include "src/identity-map.h"
(...skipping 835 matching lines...) Expand 10 before | Expand all | Expand 10 after
846 } 846 }
847 // 21. Return trapResult. 847 // 21. Return trapResult.
848 return AddKeysFromJSProxy(proxy, trap_result); 848 return AddKeysFromJSProxy(proxy, trap_result);
849 } 849 }
850 850
851 Maybe<bool> KeyAccumulator::CollectOwnJSProxyTargetKeys( 851 Maybe<bool> KeyAccumulator::CollectOwnJSProxyTargetKeys(
852 Handle<JSProxy> proxy, Handle<JSReceiver> target) { 852 Handle<JSProxy> proxy, Handle<JSReceiver> target) {
853 // TODO(cbruni): avoid creating another KeyAccumulator 853 // TODO(cbruni): avoid creating another KeyAccumulator
854 Handle<FixedArray> keys; 854 Handle<FixedArray> keys;
855 ASSIGN_RETURN_ON_EXCEPTION_VALUE( 855 ASSIGN_RETURN_ON_EXCEPTION_VALUE(
856 isolate_, keys, JSReceiver::OwnPropertyKeys(target), Nothing<bool>()); 856 isolate_, keys,
857 KeyAccumulator::GetKeys(target, KeyCollectionMode::kOwnOnly, filter_,
858 GetKeysConversion::kConvertToString,
859 filter_proxy_keys_, is_for_in_),
860 Nothing<bool>());
857 bool prev_filter_proxy_keys_ = filter_proxy_keys_; 861 bool prev_filter_proxy_keys_ = filter_proxy_keys_;
858 filter_proxy_keys_ = false; 862 filter_proxy_keys_ = false;
859 Maybe<bool> result = AddKeysFromJSProxy(proxy, keys); 863 Maybe<bool> result = AddKeysFromJSProxy(proxy, keys);
860 filter_proxy_keys_ = prev_filter_proxy_keys_; 864 filter_proxy_keys_ = prev_filter_proxy_keys_;
861 return result; 865 return result;
862 } 866 }
863 867
864 } // namespace internal 868 } // namespace internal
865 } // namespace v8 869 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698