Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/keys.h

Issue 2129193003: [keys] propagate PropertyFilter to proxy targets in KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add tests from the bug Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/keys.cc » ('j') | src/keys.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_KEYS_H_ 5 #ifndef V8_KEYS_H_
6 #define V8_KEYS_H_ 6 #define V8_KEYS_H_
7 7
8 #include "src/isolate.h" 8 #include "src/isolate.h"
9 #include "src/objects.h" 9 #include "src/objects.h"
10 10
(...skipping 25 matching lines...) Expand all
36 : isolate_(isolate), mode_(mode), filter_(filter) {} 36 : isolate_(isolate), mode_(mode), filter_(filter) {}
37 ~KeyAccumulator(); 37 ~KeyAccumulator();
38 38
39 static MaybeHandle<FixedArray> GetKeys( 39 static MaybeHandle<FixedArray> GetKeys(
40 Handle<JSReceiver> object, KeyCollectionMode mode, PropertyFilter filter, 40 Handle<JSReceiver> object, KeyCollectionMode mode, PropertyFilter filter,
41 GetKeysConversion keys_conversion = GetKeysConversion::kKeepNumbers, 41 GetKeysConversion keys_conversion = GetKeysConversion::kKeepNumbers,
42 bool filter_proxy_keys = true, bool is_for_in = false); 42 bool filter_proxy_keys = true, bool is_for_in = false);
43 43
44 Handle<FixedArray> GetKeys( 44 Handle<FixedArray> GetKeys(
45 GetKeysConversion convert = GetKeysConversion::kKeepNumbers); 45 GetKeysConversion convert = GetKeysConversion::kKeepNumbers);
46 Maybe<bool> CollectKeys(Handle<JSReceiver> receiver, 46 Maybe<bool> CollectKeys(
47 Handle<JSReceiver> object); 47 Handle<JSReceiver> receiver, Handle<JSReceiver> object,
48 GetKeysConversion keys_conversion = GetKeysConversion::kKeepNumbers);
48 Maybe<bool> CollectOwnElementIndices(Handle<JSReceiver> receiver, 49 Maybe<bool> CollectOwnElementIndices(Handle<JSReceiver> receiver,
49 Handle<JSObject> object); 50 Handle<JSObject> object);
50 Maybe<bool> CollectOwnPropertyNames(Handle<JSReceiver> receiver, 51 Maybe<bool> CollectOwnPropertyNames(Handle<JSReceiver> receiver,
51 Handle<JSObject> object); 52 Handle<JSObject> object);
52 Maybe<bool> CollectAccessCheckInterceptorKeys( 53 Maybe<bool> CollectAccessCheckInterceptorKeys(
53 Handle<AccessCheckInfo> access_check_info, Handle<JSReceiver> receiver, 54 Handle<AccessCheckInfo> access_check_info, Handle<JSReceiver> receiver,
54 Handle<JSObject> object); 55 Handle<JSObject> object);
55 56
56 static Handle<FixedArray> GetOwnEnumPropertyKeys(Isolate* isolate, 57 static Handle<FixedArray> GetOwnEnumPropertyKeys(Isolate* isolate,
57 Handle<JSObject> object); 58 Handle<JSObject> object);
(...skipping 25 matching lines...) Expand all
83 } 84 }
84 // Shadowing keys are used to filter keys. This happens when non-enumerable 85 // Shadowing keys are used to filter keys. This happens when non-enumerable
85 // keys appear again on the prototype chain. 86 // keys appear again on the prototype chain.
86 void AddShadowKey(Object* key); 87 void AddShadowKey(Object* key);
87 void AddShadowKey(Handle<Object> key); 88 void AddShadowKey(Handle<Object> key);
88 89
89 private: 90 private:
90 Maybe<bool> CollectOwnKeys(Handle<JSReceiver> receiver, 91 Maybe<bool> CollectOwnKeys(Handle<JSReceiver> receiver,
91 Handle<JSObject> object); 92 Handle<JSObject> object);
92 Maybe<bool> CollectOwnJSProxyKeys(Handle<JSReceiver> receiver, 93 Maybe<bool> CollectOwnJSProxyKeys(Handle<JSReceiver> receiver,
93 Handle<JSProxy> proxy); 94 Handle<JSProxy> proxy,
95 GetKeysConversion keys_conversion);
94 Maybe<bool> CollectOwnJSProxyTargetKeys(Handle<JSProxy> proxy, 96 Maybe<bool> CollectOwnJSProxyTargetKeys(Handle<JSProxy> proxy,
95 Handle<JSReceiver> target); 97 Handle<JSReceiver> target,
98 GetKeysConversion keys_conversion);
96 Maybe<bool> AddKeysFromJSProxy(Handle<JSProxy> proxy, 99 Maybe<bool> AddKeysFromJSProxy(Handle<JSProxy> proxy,
97 Handle<FixedArray> keys); 100 Handle<FixedArray> keys);
98 bool IsShadowed(Handle<Object> key); 101 bool IsShadowed(Handle<Object> key);
99 Handle<OrderedHashSet> keys() { return Handle<OrderedHashSet>::cast(keys_); } 102 Handle<OrderedHashSet> keys() { return Handle<OrderedHashSet>::cast(keys_); }
100 103
101 Isolate* isolate_; 104 Isolate* isolate_;
102 // keys_ is either an Handle<OrderedHashSet> or in the case of own JSProxy 105 // keys_ is either an Handle<OrderedHashSet> or in the case of own JSProxy
103 // keys a Handle<FixedArray>. The OrderedHashSet is in-place converted to the 106 // keys a Handle<FixedArray>. The OrderedHashSet is in-place converted to the
104 // result list, a FixedArray containing all collected keys. 107 // result list, a FixedArray containing all collected keys.
105 Handle<FixedArray> keys_; 108 Handle<FixedArray> keys_;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 bool is_receiver_simple_enum_ = false; 152 bool is_receiver_simple_enum_ = false;
150 bool has_empty_prototype_ = false; 153 bool has_empty_prototype_ = false;
151 154
152 DISALLOW_COPY_AND_ASSIGN(FastKeyAccumulator); 155 DISALLOW_COPY_AND_ASSIGN(FastKeyAccumulator);
153 }; 156 };
154 157
155 } // namespace internal 158 } // namespace internal
156 } // namespace v8 159 } // namespace v8
157 160
158 #endif // V8_KEYS_H_ 161 #endif // V8_KEYS_H_
OLDNEW
« no previous file with comments | « no previous file | src/keys.cc » ('j') | src/keys.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698