Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2129183002: Support checked mode (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support checked mode Checked mode checks are now always stored in the WorldImpact meaning that data doesn't have to be serialized with checked mode enabled. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/38dd1553e8fd864aa75cf2d3f04223ade919130f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +5 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/compilation_test_helper.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-11 13:25:46 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-11 15:51:45 UTC) #3
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-11 15:53:50 UTC) #4
Johnni Winther
4 years, 5 months ago (2016-07-12 08:10:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38dd1553e8fd864aa75cf2d3f04223ade919130f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698