Issue 2129143002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2129143002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently (Closed)

Created:
4 years, 5 months ago by keishi

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently When JS iteratively constructs a DOM tree containing form controls, didAssociateFormControlsTimer was fireing for every iteration, causing a massive slow down. BUG=614856 Review-Url: https://codereview.chromium.org/2055693002 Cr-Commit-Position: refs/heads/master@{#404083} (cherry picked from commit 6e1c00f9b9656319829c290a280b5ffb07bc4d1a)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -6 lines)			Patch
M	chrome/renderer/autofill/autofill_renderer_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/autofill/password_generation_agent_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/chrome_render_view_test.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_test.cc	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

keishi

4 years, 5 months ago (2016-07-08 09:38:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
50d0ab59c2dc8df792713dbe8169fcaa9983bccd.

Expand Messages | Collapse Messages