Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 212913005: Add LLVM 'unreachable' instruction to list of allowed instructions. (Closed)

Created:
6 years, 9 months ago by Jim Stichnoth
Modified:
6 years, 9 months ago
Reviewers:
Mark Seaborn, Karl
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Add LLVM 'unreachable' instruction to list of allowed instructions. BUG= none TEST= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259736

Patch Set 1 #

Patch Set 2 : Update html file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M native_client_sdk/doc_generated/reference/pnacl-bitcode-abi.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jim Stichnoth
6 years, 9 months ago (2014-03-26 17:57:05 UTC) #1
Mark Seaborn
LGTM
6 years, 9 months ago (2014-03-26 18:06:13 UTC) #2
Karl
lgtm
6 years, 9 months ago (2014-03-26 21:44:08 UTC) #3
Jim Stichnoth
The html file needs to be updated as well.
6 years, 9 months ago (2014-03-26 22:10:23 UTC) #4
Karl
lgtm
6 years, 9 months ago (2014-03-26 22:14:46 UTC) #5
Jim Stichnoth
The CQ bit was checked by stichnot@chromium.org
6 years, 9 months ago (2014-03-26 22:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stichnot@chromium.org/212913005/20001
6 years, 9 months ago (2014-03-26 22:20:26 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 22:56:09 UTC) #8
Message was sent while issue was closed.
Change committed as 259736

Powered by Google App Engine
This is Rietveld 408576698