Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2129123002: [turbofan] Re-enable test that no longer fails. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-enable test that no longer fails. This enables tests which rely on the context available at "debugger" statements to be accurate. This is the case by now when deoptimization information is available. R=yangguo@chromium.org BUG=v8:4055 Committed: https://chromium.googlesource.com/v8/v8/+/2c09760ac449dd7a662f80299275b76d15bde440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-08 08:55:03 UTC) #1
Yang
On 2016/07/08 08:55:03, Michael Starzinger wrote: lgtm
4 years, 5 months ago (2016-07-08 09:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129123002/1
4 years, 5 months ago (2016-07-08 09:16:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19066)
4 years, 5 months ago (2016-07-08 09:22:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c09760ac449dd7a662f80299275b76d15bde440 Cr-Commit-Position: refs/heads/master@{#37604}
4 years, 5 months ago (2016-07-08 09:52:13 UTC) #8
Michael Starzinger
4 years, 5 months ago (2016-07-08 09:52:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c09760ac449dd7a662f80299275b76d15bde440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698