Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2129113002: Re-add accidentally deleted unittests (Closed)

Created:
4 years, 5 months ago by Rob Percival
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add accidentally deleted unittests Unintentionally removed by https://codereview.chromium.org/2066553002/#ps440001 (https://crrev.com/2c7cd56d182ae1a14191170c47154641a24633fa). Committed: https://crrev.com/bd08b05bdadf887b946e63feef9d704f821beb75 Cr-Commit-Position: refs/heads/master@{#404368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/components_tests.gyp View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Rob Percival
4 years, 5 months ago (2016-07-08 08:49:22 UTC) #2
Primiano Tucci (use gerrit)
Thanks LGTM but please extend the commit message mentioning the fact that those entries were ...
4 years, 5 months ago (2016-07-08 08:51:08 UTC) #3
Rob Percival
On 2016/07/08 08:51:08, Primiano Tucci wrote: > Thanks LGTM but please extend the commit message ...
4 years, 5 months ago (2016-07-08 08:54:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129113002/1
4 years, 5 months ago (2016-07-08 08:55:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:20:29 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:21:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd08b05bdadf887b946e63feef9d704f821beb75
Cr-Commit-Position: refs/heads/master@{#404368}

Powered by Google App Engine
This is Rietveld 408576698