Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129093002: Remove ApplicationCache runtime flag (status=stable) (Closed)

Created:
4 years, 5 months ago by HyungwookLee
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ApplicationCache runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/f67cb8db57391f982744179442638bfbd5595320 Cr-Commit-Position: refs/heads/master@{#404525}

Patch Set 1 #

Patch Set 2 : Add some unit tests for MemoryCache. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -9 lines) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp View 1 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
HyungwookLee
PTAL.
4 years, 5 months ago (2016-07-08 03:17:17 UTC) #5
Mike West
LGTM.
4 years, 5 months ago (2016-07-08 06:56:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129093002/1
4 years, 5 months ago (2016-07-08 07:16:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/214151)
4 years, 5 months ago (2016-07-08 07:26:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129093002/1
4 years, 5 months ago (2016-07-08 07:55:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/214166)
4 years, 5 months ago (2016-07-08 08:04:10 UTC) #14
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-08 14:15:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129093002/1
4 years, 5 months ago (2016-07-08 23:02:08 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:07:46 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:10:10 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f67cb8db57391f982744179442638bfbd5595320
Cr-Commit-Position: refs/heads/master@{#404525}

Powered by Google App Engine
This is Rietveld 408576698