Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2129083003: Revert of MIPS: [turbofan] Fix addition for deoptimization. (Closed)

Created:
4 years, 5 months ago by miran.karic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: [turbofan] Fix addition for deoptimization. (patchset #3 id:40001 of https://codereview.chromium.org/2102063002/ ) Reason for revert: This workaround is no longer needed, port of e60c4053c7f9d6e44b995c77ab3ec561aec83c9c fixes the issue. Original issue's description: > MIPS: [turbofan] Fix addition for deoptimization. > > In turbofan, after an addition operation where the same register is the > output and both inputs, if deoptimization is performed the input is > overwritten with the output value and the final result is not correct. > This is fixed by restoring the original value of the input before > deoptimization. > > BUG= > TEST=mjsunit/regress/regress-int32-truncation > > Committed: https://crrev.com/99385e8e4bcef1f333ede61c936528bfc0c8ecfa > Cr-Commit-Position: refs/heads/master@{#37524} TBR=akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,ivica.bogosavljevic@imgtec.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/29b89b489a20e1402eb17f9806bca16b7bc44c2b Cr-Commit-Position: refs/heads/master@{#37612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
miran.karic
Created Revert of MIPS: [turbofan] Fix addition for deoptimization.
4 years, 5 months ago (2016-07-08 13:07:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129083003/1
4 years, 5 months ago (2016-07-08 13:08:02 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-08 13:08:04 UTC) #5
balazs.kilvady
lgtm
4 years, 5 months ago (2016-07-08 13:11:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129083003/1
4 years, 5 months ago (2016-07-08 13:12:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129083003/1
4 years, 5 months ago (2016-07-08 13:46:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129083003/1
4 years, 5 months ago (2016-07-08 14:01:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:57:29 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:57:31 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:57:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29b89b489a20e1402eb17f9806bca16b7bc44c2b
Cr-Commit-Position: refs/heads/master@{#37612}

Powered by Google App Engine
This is Rietveld 408576698