Issue 2129043004: Don't load arguments descriptor for optimized static calls.

Issue 2129043004: Don't load arguments descriptor for optimized static calls. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't load arguments descriptor for optimized static calls. For static function invocations that don't have optional arguments we can load smi zero instead of the arguments descriptor. Code is slightly smaller, and it avoids loading from the object pool. BUG=#25991 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/01c7df40b60eb0961f08bd2385dd440c5e3d24bb

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -66 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	3 chunks	+10 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	3 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	3 chunks	+8 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	3 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	3 chunks	+9 lines, -13 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 5 months ago (2016-07-08 23:49:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01c7df40b60eb0961f08bd2385dd440c5e3d24bb (presubmit successful).