Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: ui/gl/gl_implementation_android.cc

Issue 2129043003: Make dynamic mock bindings initialization consistent with other GL implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_implementation.h ('k') | ui/gl/gl_implementation_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_implementation_android.cc
diff --git a/ui/gl/gl_implementation_android.cc b/ui/gl/gl_implementation_android.cc
index 0ca23f8a3f6ae2350af868facca874192c57f7a9..0608b2e4685d6c1b50d849c6dc2d4f50be7f93ca 100644
--- a/ui/gl/gl_implementation_android.cc
+++ b/ui/gl/gl_implementation_android.cc
@@ -18,31 +18,6 @@ void GetAllowedGLImplementations(std::vector<GLImplementation>* impls) {
impls->push_back(kGLImplementationOSMesaGL);
}
-bool InitializeDynamicGLBindings(GLImplementation implementation,
- GLContext* context) {
- switch (implementation) {
- case kGLImplementationEGLGLES2:
- case kGLImplementationOSMesaGL:
- InitializeDynamicGLBindingsGL(context);
- break;
- case kGLImplementationMockGL:
- if (!context) {
- scoped_refptr<GLContextStubWithExtensions> mock_context(
- new GLContextStubWithExtensions());
- mock_context->SetGLVersionString("opengl es 3.0");
- InitializeDynamicGLBindingsGL(mock_context.get());
- } else {
- InitializeDynamicGLBindingsGL(context);
- }
- break;
- default:
- NOTREACHED() << "InitializeDynamicGLBindings on Android";
- return false;
- }
-
- return true;
-}
-
bool GetGLWindowSystemBindingInfo(GLWindowSystemBindingInfo* info) {
switch (GetGLImplementation()) {
case kGLImplementationEGLGLES2:
« no previous file with comments | « ui/gl/gl_implementation.h ('k') | ui/gl/gl_implementation_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698