ui/gl/gl_context.cc - Issue 2129043003: Make dynamic mock bindings initialization consistent with other GL implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_context.cc

Issue 2129043003: Make dynamic mock bindings initialization consistent with other GL implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_context.cc

diff --git a/ui/gl/gl_context.cc b/ui/gl/gl_context.cc

index 46d566e42ea4e323a8daf7a19994adb744bbb83f..8037006b23397767691768cac7ee5150815e745c 100644

--- a/ui/gl/gl_context.cc

+++ b/ui/gl/gl_context.cc

@@ -178,12 +178,9 @@ bool GLContext::WasAllocatedUsingRobustnessExtension() {

return false;

}

-bool GLContext::InitializeDynamicBindings() {

+void GLContext::InitializeDynamicBindings() {

DCHECK(IsCurrent(nullptr));

- bool initialized = InitializeDynamicGLBindings(GetGLImplementation(), this);

- if (!initialized)

- LOG(ERROR) << "Could not initialize dynamic bindings.";

- return initialized;

+ InitializeDynamicGLBindingsGL(this);

}

void GLContext::SetupForVirtualization() {

« no previous file with comments | « ui/gl/gl_context.h ('k') | ui/gl/gl_context_cgl.cc » ('j') | no next file with comments »