chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc - Issue 2129043002: Split ShortcutHelper#addShortcut() into separate functions for each type of shortcut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 2129043002: Split ShortcutHelper#addShortcut() into separate functions for each type of shortcut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_builder_impl0 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

index bc55cb26db57533d4050e4ae37e0a09bc64cecdf..ba6732f42240274e61db5447ba35c5c9549c86bc 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

@@ -122,7 +122,7 @@ void AddToHomescreenDialogHelper::AddShortcut(const ShortcutInfo& info,

const std::string& uid = base::GenerateGUID();

content::BrowserThread::PostTask(

content::BrowserThread::IO, FROM_HERE,

- base::Bind(&ShortcutHelper::AddShortcutInBackgroundWithSkBitmap, info,

+ base::Bind(&ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap, info,

uid, icon,

data_fetcher_->FetchSplashScreenImageCallback(uid)));

}

« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | no next file » | no next file with comments »