Issue 2129033003: Options validation cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2129033003: Options validation cleanup. (Closed)

Created:
4 years, 5 months ago by pquitslund

Modified:
4 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Options validation cleanup. Removed deprecated `enableConditionalDirectives` in favor of `enableTrailingCommas` (temporary as it may be). BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/04bd632b239dacc1c45a7970dc8a4ac0f5d75267

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	pkg/analyzer/lib/src/task/options.dart	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

4 years, 5 months ago (2016-07-08 19:51:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
04bd632b239dacc1c45a7970dc8a4ac0f5d75267 (presubmit successful).