Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2129033002: Update scrollbars from FrameView::show. Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Set needsLayout() in FrameView::show() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/iframe-hide-show-scrollbars-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 3994 matching lines...) Expand 10 before | Expand all | Expand 10 after
4005 4005
4006 if (!isSelfVisible()) 4006 if (!isSelfVisible())
4007 return; 4007 return;
4008 4008
4009 for (const auto& child : m_children) 4009 for (const auto& child : m_children)
4010 child->setParentVisible(visible); 4010 child->setParentVisible(visible);
4011 } 4011 }
4012 4012
4013 void FrameView::show() 4013 void FrameView::show()
4014 { 4014 {
4015 setNeedsLayout();
4015 if (!isSelfVisible()) { 4016 if (!isSelfVisible()) {
4016 setSelfVisible(true); 4017 setSelfVisible(true);
4017 setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree ); 4018 setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree );
4018 updateScrollableAreaSet(); 4019 updateScrollableAreaSet();
4019 if (isParentVisible()) { 4020 if (isParentVisible()) {
4020 for (const auto& child : m_children) 4021 for (const auto& child : m_children)
4021 child->setParentVisible(true); 4022 child->setParentVisible(true);
4022 } 4023 }
4023 } 4024 }
4024 4025
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
4246 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4247 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4247 } 4248 }
4248 4249
4249 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4250 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4250 { 4251 {
4251 ASSERT(!layoutViewItem().isNull()); 4252 ASSERT(!layoutViewItem().isNull());
4252 return *layoutView(); 4253 return *layoutView();
4253 } 4254 }
4254 4255
4255 } // namespace blink 4256 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/iframe-hide-show-scrollbars-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698