Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2129023002: SELECT element: Fix a DCHECK failure after crrev.com/404091 (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Fix a DCHECK failure after crrev.com/404091 On Android, selectedOption(), which is the first selected OPTION in tree order, and m_lastOnChangeOption can be different because Android has menulist+multiple configuration. BUG=626328 TBR=keishi@chromium.org Committed: https://crrev.com/473363e7400323f30342b03a90c2f3da4959fe6a Cr-Commit-Position: refs/heads/master@{#404302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
4 years, 5 months ago (2016-07-07 23:27:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129023002/1
4 years, 5 months ago (2016-07-07 23:29:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 01:32:34 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:32:36 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:34:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/473363e7400323f30342b03a90c2f3da4959fe6a
Cr-Commit-Position: refs/heads/master@{#404302}

Powered by Google App Engine
This is Rietveld 408576698