Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2128963002: Revert of Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)
Modified:
4 years, 5 months ago
Reviewers:
dsansome
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. (patchset #1 id:1 of https://codereview.chromium.org/2108553002/ ) Reason for revert: possible cause of https://bugs.chromium.org/p/chromium/issues/detail?id=626354. Original issue's description: > Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. > > This commit was only added in the 0.8.4 branch, and was never made to master. > > The bug only happens when starting buildbot with "make start", but we start it > directly with twistd in Chrome: http://trac.buildbot.net/ticket/1992 > > BUG=620572 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/8c7a5b159b444e0193f9b2d8a094d352c226e7d1 TBR=dsansome@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8a713dd3408bd0dc54a3972ce0415457eab57acd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 5 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ghost stip (do not use)
Created Revert of Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5.
4 years, 5 months ago (2016-07-07 20:46:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128963002/1
4 years, 5 months ago (2016-07-07 20:46:21 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 20:51:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8a713dd3408bd0dc54a3...

Powered by Google App Engine
This is Rietveld 408576698