Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2128953002: Revert of Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)
Modified:
4 years, 5 months ago
Reviewers:
dsansome
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@buildbot-version-2
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: (patchset #2 id:20001 of https://codereview.chromium.org/2103053002/ ) Reason for revert: possible cause of https://bugs.chromium.org/p/chromium/issues/detail?id=626354. Original issue's description: > Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: > > Re-run queries after certain OperationalErrors > > Sometimes malformed SQL can generate an OperationalError, so this looks > at the message itself. It's unclear how this will work with > localization. > > The code uses an exponential backoff algorithm (with a relatively small > multiplier), and will retry for a day, which seems a reasonable > get-the-db-server-fixed time. > > Fixes #2005. Hoepfully for good! > > BUG=620572 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d24f5663861a7ae00e544f96e5c2e35787ecf4d TBR=dsansome@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e9fc858ef555c00dc22fadf5514caed65c2b43e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -121 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 2 chunks +51 lines, -75 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/test/unit/test_db_pool.py View 2 chunks +1 line, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ghost stip (do not use)
Created Revert of Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9:
4 years, 5 months ago (2016-07-07 20:13:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128953002/1
4 years, 5 months ago (2016-07-07 20:13:42 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 20:16:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e9fc858ef555c00dc22f...

Powered by Google App Engine
This is Rietveld 408576698