Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 212893005: Revert "Change event handling order in HTMLPlugInElement." (Closed)

Created:
6 years, 9 months ago by teravest
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Change event handling order in HTMLPlugInElement." This reverts commit fada04e1ba92f2e951341da3ef52145dc96297bf. This change affected the behavior of flash on google maps. I'm reverting this for now to get rid of this regression. I hope to address this in a future change by altering this behavior only for non-Flash PPAPI applications. BUG=324351, 356089 TBR=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -70 lines) Patch
D LayoutTests/plugins/plugin-event-filtering.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/plugins/plugin-event-filtering-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 6 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
teravest
6 years, 9 months ago (2014-03-26 16:02:03 UTC) #1
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 9 months ago (2014-03-27 17:14:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/212893005/1
6 years, 9 months ago (2014-03-27 17:14:54 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:26:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 17:26:20 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-27 17:54:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/212893005/1
6 years, 9 months ago (2014-03-27 17:54:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 18:20:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 18:20:58 UTC) #9
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 9 months ago (2014-03-28 14:57:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/212893005/1
6 years, 9 months ago (2014-03-28 14:57:27 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 15:58:39 UTC) #12
Message was sent while issue was closed.
Change committed as 170336

Powered by Google App Engine
This is Rietveld 408576698