Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 212893002: Use monotonicallyIncreasingTime for Timeline timestamps (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 8 months ago
Reviewers:
alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Use monotonicallyIncreasingTime for Timeline timestamps We used to use pseudo-wall time for Timeline timestamps and had a hard time converting back-n-forth between monotonicallyIncreasingTime used by other subsystems and Timeline. This switches Timeline to monotonicallyIncreasingTime. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170444

Patch Set 1 #

Patch Set 2 : scale to milliseconds #

Total comments: 2

Patch Set 3 : removed toTimtlineTimestamp() #

Patch Set 4 : removed a test, it's not applicable now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -85 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-start-time.html View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-start-time-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 2 15 chunks +16 lines, -26 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
caseq
6 years, 9 months ago (2014-03-26 13:29:57 UTC) #1
caseq
6 years, 9 months ago (2014-03-26 14:06:36 UTC) #2
pfeldman
https://codereview.chromium.org/212893002/diff/40001/Source/core/inspector/InspectorTimelineAgent.cpp File Source/core/inspector/InspectorTimelineAgent.cpp (left): https://codereview.chromium.org/212893002/diff/40001/Source/core/inspector/InspectorTimelineAgent.cpp#oldcode261 Source/core/inspector/InspectorTimelineAgent.cpp:261: m_startOffset = monotonicallyIncreasingTime() - currentTime(); I am not sure ...
6 years, 9 months ago (2014-03-27 13:26:57 UTC) #3
caseq
On 2014/03/27 13:26:57, pfeldman wrote: > https://codereview.chromium.org/212893002/diff/40001/Source/core/inspector/InspectorTimelineAgent.cpp > File Source/core/inspector/InspectorTimelineAgent.cpp (left): > > https://codereview.chromium.org/212893002/diff/40001/Source/core/inspector/InspectorTimelineAgent.cpp#oldcode261 > ...
6 years, 8 months ago (2014-03-31 07:56:55 UTC) #4
alph
Make sure it won't break any tests. I remember there was one that expected timestamps ...
6 years, 8 months ago (2014-03-31 08:27:42 UTC) #5
pfeldman
lgtm
6 years, 8 months ago (2014-03-31 09:25:51 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-03-31 09:33:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/212893002/70001
6 years, 8 months ago (2014-03-31 09:33:50 UTC) #8
alph
On 2014/03/31 09:33:50, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-03-31 09:42:46 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 09:44:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-31 09:44:21 UTC) #11
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-03-31 12:19:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/212893002/90001
6 years, 8 months ago (2014-03-31 12:19:59 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 12:53:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-31 12:53:13 UTC) #15
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-03-31 13:00:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/212893002/90001
6 years, 8 months ago (2014-03-31 13:00:33 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 13:49:59 UTC) #18
Message was sent while issue was closed.
Change committed as 170444

Powered by Google App Engine
This is Rietveld 408576698