Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2128923003: Small tweaks to hot reload testing (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rmacnak review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index c73dc7c28841b77b49774be1b91550146699059b..70230f4983ad348c0f46fa42e51d107c5b665256 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -300,6 +300,14 @@ abstract class TestSuite {
return;
}
+ if (configuration['hot_reload']) {
+ // Handle reload special cases.
+ if (expectations.contains(Expectation.COMPILETIME_ERROR)) {
+ // Skip reloading tests with expected compilation errors.
+ return;
+ }
+ }
+
// Update Summary report
if (configuration['report']) {
if (testCase.expectCompileError &&
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698