Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2128923003: Small tweaks to hot reload testing (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Small tweaks to hot reload testing - [x] Start reloading 5x sooner in test mode. - [x] Skip mirrors tests for now. - [x] Skip reloading tests that expect compile time errors. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/dc1b2bf58094674e08f23caaea4bb049a5378779

Patch Set 1 #

Total comments: 2

Patch Set 2 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M runtime/bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 5 months ago (2016-07-07 22:03:13 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2128923003/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/2128923003/diff/1/tests/lib/lib.status#newcode6 tests/lib/lib.status:6: mirrors/*: Skip # Issue 26836 Please use the ...
4 years, 5 months ago (2016-07-08 01:06:20 UTC) #4
Cutch
https://codereview.chromium.org/2128923003/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/2128923003/diff/1/tests/lib/lib.status#newcode6 tests/lib/lib.status:6: mirrors/*: Skip # Issue 26836 On 2016/07/08 01:06:19, rmacnak ...
4 years, 5 months ago (2016-07-08 13:51:13 UTC) #5
Cutch
4 years, 5 months ago (2016-07-08 13:51:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc1b2bf58094674e08f23caaea4bb049a5378779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698