Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 2128843002: tryserver.chromium.linux: disable time-without-output timeout when build timeout is used (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

tryserver.chromium.linux: disable time-without-output timeout when build timeout is used BUG=622373 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c3e4c75d8ee898904edeceb683625d5ac2d13d8e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-07 13:37:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128843002/1
4 years, 5 months ago (2016-07-07 13:37:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:41:20 UTC) #6
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-07 13:44:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128843002/1
4 years, 5 months ago (2016-07-07 13:51:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/c3e4c75d8ee898904edeceb683625d5ac2d13d8e
4 years, 5 months ago (2016-07-07 13:54:07 UTC) #11
Sergiy Byelozyorov
4 years, 5 months ago (2016-07-08 08:20:43 UTC) #12
Message was sent while issue was closed.
Can we please improve the comment in a follow-up CL? It's somewhat confusing to
me.

https://codereview.chromium.org/2128843002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/2128843002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.linux/master.cfg:63: if 'max_time' in kwargs
and 'timeout' not in kwargs:
The comment and statement is confusing. Comment says that we disable 'max time
without output timeout', which seems to correspond to max_time variable, yet we
change timeout property. Perhaps mention which timeout corresponds to which
variable in kwargs. I think it also makes sense to mention that by default
timeout is 2400, otherwise it's not clear why we set timeout to 'None' if it's
not set.

Powered by Google App Engine
This is Rietveld 408576698