Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 212883011: Changes bookmark bar drag widget to be semitransparent (Closed)

Created:
6 years, 9 months ago by varkha
Modified:
6 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changes drag widgets such as bookmark bar items that are dragged to be semitransparent. BUG=349154 TEST=Visual - check that a bookmark widget is semitransparent during the drag and appears over, not under the bookmark menus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
varkha
sadrul@, this is a spin-off from https://codereview.chromium.org/196213004/. Can you please take a look? This can ...
6 years, 9 months ago (2014-03-27 04:54:00 UTC) #1
sadrul
This makes all drag-widgets semitransparent, right (and not just the bookmark-bar ones)? Please update the ...
6 years, 9 months ago (2014-03-27 19:15:42 UTC) #2
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 9 months ago (2014-03-27 20:08:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/212883011/1
6 years, 9 months ago (2014-03-27 20:09:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:41:52 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 23:41:52 UTC) #6
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 9 months ago (2014-03-27 23:56:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/212883011/1
6 years, 9 months ago (2014-03-27 23:58:24 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:02:37 UTC) #9
Message was sent while issue was closed.
Change committed as 260034

Powered by Google App Engine
This is Rietveld 408576698