Handle creating ParameterMirrors for the parameters of forwarding constructors.

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
@@ skipping 111 matching lines @@
   const intptr_t implicit_param_count = func.NumImplicitParameters();
   const intptr_t non_implicit_param_count = func.NumParameters() -
                                             implicit_param_count;
   const intptr_t index_of_first_optional_param =
       non_implicit_param_count - func.NumOptionalParameters();
   const intptr_t index_of_first_named_param =
       non_implicit_param_count - func.NumOptionalNamedParameters();
   const Array& results = Array::Handle(Array::New(non_implicit_param_count));
   const Array& args = Array::Handle(Array::New(9));
 
-  // Return for synthetic functions and getters.
-  if (func.IsGetterFunction() ||
-      func.IsImplicitConstructor() ||
-      func.IsImplicitGetterFunction() ||
-      func.IsImplicitSetterFunction()) {
+  if (func.IsForwardingConstructor()) {

[hausner, 2014/03/27 17:10:27]

Curious: why don't you do this test at the beginning of the function?

+    // Forwarding constructors for mixin applications don't have any source to
+    // parse, but they do have parameters. Use the names/types/metadata from
+    // constructor that we are forwarding to. We will probably have to revisit
+    // this when restrictions on constructors in mixins are relaxed.
+    const Function& target = Function::Handle(func.ForwardingTarget());
+    ASSERT(!target.IsNull());
+    return CreateParameterMirrorList(target, owner_mirror);
+  }
+
+  if (func.IsGetterFunction() || func.IsImplicitConstructor()) {
+    // These have no parameters.
+    ASSERT(results.Length() == 0);
     return results.raw();
   }
 
   Smi& pos = Smi::Handle();
   String& name = String::Handle();
   Instance& param = Instance::Handle();
   Bool& is_final = Bool::Handle();
   Object& default_value = Object::Handle();
   Object& metadata = Object::Handle();
 
@@ skipping 2083 matching lines @@
 }
 
 DEFINE_NATIVE_ENTRY(TypeMirror_moreSpecificTest, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));
   return Bool::Get(a.IsMoreSpecificThan(b, NULL)).raw();
 }
 
 
 }  // namespace dart