Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 212883008: Add DHE_RSA support to tlslite. (Closed)

Created:
6 years, 9 months ago by davidben
Modified:
6 years, 8 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add DHE_RSA support to tlslite. Needed for our test server to be able to False Start. BUG=354132 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263169

Patch Set 1 #

Total comments: 26

Patch Set 2 : wtc comments #

Total comments: 2

Patch Set 3 : spaces #

Total comments: 31

Patch Set 4 : wtc comments. #

Total comments: 2

Patch Set 5 : Rebase and address wtc comment. #

Patch Set 6 : Update patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -39 lines) Patch
M net/tools/testserver/testserver.py View 1 2 3 4 4 chunks +13 lines, -1 line 0 comments Download
M third_party/tlslite/README.chromium View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/tlslite/patches/dhe_rsa.patch View 1 2 3 4 5 1 chunk +417 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 7 chunks +38 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 2 3 4 chunks +11 lines, -1 line 0 comments Download
M third_party/tlslite/tlslite/messages.py View 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 1 2 3 4 7 chunks +129 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
davidben
Context for domino chain: https://crbug.com/354132#c1 Sending this out for review ahead of time, but note ...
6 years, 8 months ago (2014-03-31 15:52:55 UTC) #1
Ryan Sleevi
Quick review LG, but I'll need to mentally page in more of TLSLite 0.4.3 https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/tlslite/tlsconnection.py ...
6 years, 8 months ago (2014-03-31 20:43:57 UTC) #2
davidben
https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/tlslite/tlsconnection.py#newcode42 third_party/tlslite/tlslite/tlsconnection.py:42: return None On 2014/03/31 20:43:57, Ryan Sleevi wrote: > ...
6 years, 8 months ago (2014-03-31 20:58:20 UTC) #3
wtc
Patch set 1 LGTM. https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/README.chromium File third_party/tlslite/README.chromium (right): https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/README.chromium#newcode31 third_party/tlslite/README.chromium:31: - patches/dhe_rsa.patch: Implement DHE_RSA-based key ...
6 years, 8 months ago (2014-04-01 22:00:01 UTC) #4
davidben
https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/README.chromium File third_party/tlslite/README.chromium (right): https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/README.chromium#newcode31 third_party/tlslite/README.chromium:31: - patches/dhe_rsa.patch: Implement DHE_RSA-based key exchanges. On 2014/04/01 22:00:01, ...
6 years, 8 months ago (2014-04-01 23:25:18 UTC) #5
wtc
Patch set 2 LGTM. https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/1/third_party/tlslite/tlslite/tlsconnection.py#newcode49 third_party/tlslite/tlslite/tlsconnection.py:49: # Bleichenbacher's "million message" attack ...
6 years, 8 months ago (2014-04-02 03:34:20 UTC) #6
davidben
https://codereview.chromium.org/212883008/diff/20001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/20001/third_party/tlslite/tlslite/tlsconnection.py#newcode104 third_party/tlslite/tlslite/tlsconnection.py:104: if not 2 <= dh_Yc <= self.dh_p-1: On 2014/04/02 ...
6 years, 8 months ago (2014-04-02 15:32:34 UTC) #7
wtc
Patch set 3 LGTM. I reviewed this CL carefully again because it is fun to ...
6 years, 8 months ago (2014-04-02 19:11:28 UTC) #8
wtc
https://codereview.chromium.org/212883008/diff/40001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/40001/third_party/tlslite/tlslite/tlsconnection.py#newcode28 third_party/tlslite/tlslite/tlsconnection.py:28: def __init__(self, cipherSuite, clientHello, serverHello, privateKey): On 2014/04/02 19:11:29, ...
6 years, 8 months ago (2014-04-02 19:13:45 UTC) #9
Ryan Sleevi
lgtm
6 years, 8 months ago (2014-04-02 22:16:07 UTC) #10
davidben
> Could you please submit your patch to the tlslite upstream? Thanks. Yeah, I'll submit ...
6 years, 8 months ago (2014-04-03 18:45:48 UTC) #11
wtc
Patch set 4 LGTM. Thanks! https://codereview.chromium.org/212883008/diff/60001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/60001/third_party/tlslite/tlslite/tlsconnection.py#newcode39 third_party/tlslite/tlslite/tlsconnection.py:39: key exchange. If the ...
6 years, 8 months ago (2014-04-03 19:10:03 UTC) #12
davidben
Aaaaand rebased onto trunk now that 0.4.6 is in. https://codereview.chromium.org/212883008/diff/60001/third_party/tlslite/tlslite/tlsconnection.py File third_party/tlslite/tlslite/tlsconnection.py (right): https://codereview.chromium.org/212883008/diff/60001/third_party/tlslite/tlslite/tlsconnection.py#newcode39 third_party/tlslite/tlslite/tlsconnection.py:39: ...
6 years, 8 months ago (2014-04-10 19:30:50 UTC) #13
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-10 21:24:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/212883008/100001
6 years, 8 months ago (2014-04-10 21:24:26 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 01:10:23 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=295885
6 years, 8 months ago (2014-04-11 01:10:24 UTC) #17
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-11 02:10:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/212883008/100001
6 years, 8 months ago (2014-04-11 02:11:30 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 07:20:36 UTC) #20
Message was sent while issue was closed.
Change committed as 263169

Powered by Google App Engine
This is Rietveld 408576698