Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: net/nqe/cached_network_quality.h

Issue 2128793003: Factor out NetworkID and caching mechanism from n_q_e.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/cached_network_quality.h
diff --git a/net/nqe/cached_network_quality.h b/net/nqe/cached_network_quality.h
index cc0af2f1b8d48d68c2d8c2fc69de14c8809c6242..62f5cb4134859244d50fe5ce4103622647400cd4 100644
--- a/net/nqe/cached_network_quality.h
+++ b/net/nqe/cached_network_quality.h
@@ -17,27 +17,36 @@ namespace nqe {
namespace internal {
// CachedNetworkQuality stores the quality of a previously seen network.
+// Cached entries are stored in LRU order, and older entries may be evicted.
RyanSturm 2016/07/12 18:45:38 This seems like a detail of the manager, not the e
tbansal1 2016/07/12 19:40:18 Moved to NetworkQualitiesManager file.
class NET_EXPORT_PRIVATE CachedNetworkQuality {
public:
- explicit CachedNetworkQuality(const NetworkQuality& network_quality);
+ CachedNetworkQuality();
+
+ // |last_update_time| is the time when the |network_quality| was computed.
+ CachedNetworkQuality(base::TimeTicks last_update_time,
+ const NetworkQuality& network_quality);
CachedNetworkQuality(const CachedNetworkQuality& other);
~CachedNetworkQuality();
// Returns the network quality associated with this cached entry.
const NetworkQuality& network_quality() const { return network_quality_; }
+ CachedNetworkQuality& operator=(const CachedNetworkQuality& other);
+
// Returns true if this cache entry was updated before
// |cached_network_quality|.
bool OlderThan(const CachedNetworkQuality& cached_network_quality) const;
- // Time when this cache entry was last updated.
- const base::TimeTicks last_update_time_;
+ base::TimeTicks last_update_time() { return last_update_time_; }
- // Quality of this cached network.
- const NetworkQuality network_quality_;
+ const NetworkQuality& network_quality() { return network_quality_; }
private:
- DISALLOW_ASSIGN(CachedNetworkQuality);
+ // Time when this cache entry was last updated.
+ base::TimeTicks last_update_time_;
+
+ // Quality of this cached network.
+ NetworkQuality network_quality_;
};
} // namespace internal
« no previous file with comments | « net/net.gypi ('k') | net/nqe/cached_network_quality.cc » ('j') | net/nqe/network_id.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698