Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2128773003: Rename DISALLOW_ALLOCATION to DISALLOW_NEW (Closed)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
keishi, oilpan-reviews, sof
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DISALLOW_ALLOCATION to DISALLOW_NEW This CL fixes a left-over from https://codereview.chromium.org/1406923009/ BUG=548217 Committed: https://crrev.com/0f21847167a6514ffd9a3e47da8405765cc1f51b Cr-Commit-Position: refs/heads/master@{#404131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/class_requires_trace_method_tmpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/fields_illegal_tracing.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/fields_require_tracing.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/heap/stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-07 10:40:09 UTC) #2
sof
lgtm
4 years, 5 months ago (2016-07-07 10:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128773003/1
4 years, 5 months ago (2016-07-07 11:01:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 11:54:41 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 11:56:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f21847167a6514ffd9a3e47da8405765cc1f51b
Cr-Commit-Position: refs/heads/master@{#404131}

Powered by Google App Engine
This is Rietveld 408576698